Fixed #1557, although it doesn't appear to be just an FF3 problem. In this case,...

[jquery.git] / src / ajax.js

diff --git a/src/ajax.js b/src/ajax.js
index b0c7f67..6821cec 100644 (file)
--- a/src/ajax.js
+++ b/src/ajax.js
@@ -163,24 +163,24 @@ jQuery.extend({
                if ( s.data && s.processData && typeof s.data != "string" )
                        s.data = jQuery.param(s.data);
 
-               // Break the data into one single string
-               var q = s.url.indexOf("?");
-               if ( q > -1 ) {
-                       s.data = (s.data ? s.data + "&" : "") + s.url.slice(q + 1);
-                       s.url = s.url.slice(0, q);
-               }
-
                // Handle JSONP Parameter Callbacks
                if ( s.dataType == "jsonp" ) {
-                       if ( !s.data || !s.data.match(jsre) )
+                       if ( s.type.toLowerCase() == "get" ) {
+                               if ( !s.url.match(jsre) )
+                                       s.url += (s.url.match(/\?/) ? "&" : "?") + (s.jsonp || "callback") + "=?";
+                       } else if ( !s.data || !s.data.match(jsre) )
                                s.data = (s.data ? s.data + "&" : "") + (s.jsonp || "callback") + "=?";
                        s.dataType = "json";
                }
 
                // Build temporary JSONP function
-               if ( s.dataType == "json" && s.data && s.data.match(jsre) ) {
+               if ( s.dataType == "json" && (s.data && s.data.match(jsre) || s.url.match(jsre)) ) {
                        jsonp = "jsonp" + jsc++;
-                       s.data = s.data.replace(jsre, "=" + jsonp);
+
+                       // Replace the =? sequence both in the query string and the data
+                       if ( s.data )
+                               s.data = (s.data + "").replace(jsre, "=" + jsonp);
+                       s.url = s.url.replace(jsre, "=" + jsonp);
 
                        // We need to make sure
                        // that a JSONP style response is executed properly
@@ -190,6 +190,7 @@ jQuery.extend({
                        window[ jsonp ] = function(tmp){
                                data = tmp;
                                success();
+                               complete();
                                // Garbage collect
                                window[ jsonp ] = undefined;
                                try{ delete window[ jsonp ]; } catch(e){}
@@ -200,11 +201,11 @@ jQuery.extend({
                        s.cache = false;
 
                if ( s.cache === false && s.type.toLowerCase() == "get" )
-                       s.data = (s.data ? s.data + "&" : "") + "_=" + (new Date()).getTime();
+                       s.url += (s.url.match(/\?/) ? "&" : "?") + "_=" + (new Date()).getTime();
 
                // If data is available, append data to url for get requests
                if ( s.data && s.type.toLowerCase() == "get" ) {
-                       s.url += "?" + s.data;
+                       s.url += (s.url.match(/\?/) ? "&" : "?") + s.data;
 
                        // IE likes to send both get and post data, prevent this
                        s.data = null;
@@ -216,13 +217,13 @@ jQuery.extend({
 
                // If we're requesting a remote document
                // and trying to load JSON or Script
-               if ( !s.url.indexOf("http") && s.dataType == "script" ) {
+               if ( !s.url.indexOf("http") && ( s.dataType == "script" || s.dataType =="json" ) ) {
                        var head = document.getElementsByTagName("head")[0];
                        var script = document.createElement("script");
                        script.src = s.url;
 
                        // Handle Script loading
-                       if ( !jsonp && (s.success || s.complete) ) {
+                       if ( !jsonp ) {
                                var done = false;
 
                                // Attach handlers for all browsers
@@ -269,7 +270,7 @@ jQuery.extend({
                        s.beforeSend(xml);
                        
                if ( s.global )
-                   jQuery.event.trigger("ajaxSend", [xml, s]);
+                       jQuery.event.trigger("ajaxSend", [xml, s]);
 
                // Wait for a response to come back
                var onreadystatechange = function(isTimeout){
@@ -396,8 +397,9 @@ jQuery.extend({
        // Determines if an XMLHttpRequest was successful or not
        httpSuccess: function( r ) {
                try {
+                       // IE error sometimes returns 1223 when it should be 204 so treat it as success, see #1450
                        return !r.status && location.protocol == "file:" ||
-                               ( r.status >= 200 && r.status < 300 ) || r.status == 304 ||
+                               ( r.status >= 200 && r.status < 300 ) || r.status == 304 || r.status == 1223 ||
                                jQuery.browser.safari && r.status == undefined;
                } catch(e){}
                return false;