Landing fixes for tickets #2935 and #2688 (Aborting ajax doesn't stop the setInterval...

[jquery.git] / src / core.js

diff --git a/src/core.js b/src/core.js
index d910f99..081c5b4 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -407,7 +407,7 @@ jQuery.fn = jQuery.prototype = {
                        if ( this.nodeType != 1 )
                                return;
 
-                       if ( value.constructor == Array && /radio|checkbox/.test( this.type ) )
+                       if ( jQuery.isArray(value) && /radio|checkbox/.test( this.type ) )
                                this.checked = (jQuery.inArray(this.value, value) >= 0 ||
                                        jQuery.inArray(this.name, value) >= 0);
 
@@ -612,10 +612,18 @@ jQuery.extend({
        },
 
        // See test/unit/core.js for details concerning this function.
-       // Since 1.3 DOM methods and function like alert
+       // Since version 1.3, DOM methods and functions like alert
        // aren't supported. They return false on IE (#2968).
+       
+       // Memory leaks appear in IE6 when applying instanceof 
+       // to the window, document or any other COM object (#3485)
+       // http://ajaxian.com/archives/working-aroung-the-instanceof-memory-leak
        isFunction: function( fn ) {
-               return fn instanceof Function;
+               return !!fn && !!fn.hasOwnProperty && fn instanceof Function;
+       },
+       
+       isArray: function( arr ){
+               return !!arr && arr.constructor == Array;
        },
 
        // check if an element is in a (or is an) XML document
@@ -1125,15 +1133,13 @@ jQuery.extend({
                return (text || "").replace( /^\s+|\s+$/g, "" );
        },
 
-       // NOTE: Due to the conflict with Scriptaculous (http://dev.jquery.com/ticket/3248)
-       // We remove support for functions since jQuery 1.3
        makeArray: function( array ) {
                var ret = [];
 
                if( array != null ){
                        var i = array.length;
                        // The window, strings (and functions) also have 'length'
-                       if( i == null || array.split || array.setInterval )
+                       if( i == null || typeof array == 'string' || jQuery.isFunction(array) || array.setInterval )
                                ret[0] = array;
                        else
                                while( i )
@@ -1341,7 +1347,7 @@ jQuery.each([ "Height", "Width" ], function(i, name){
                // Get window width or height
                return this[0] == window ?
                        // Opera reports document.body.client[Width/Height] properly in both quirks and standards
-                       jQuery.browser.opera && document.body[ "client" + name ] ||
+                       jQuery.browser.opera && document.body.parentNode[ "client" + name ] ||
 
                        // Safari reports inner[Width/Height] just fine (Mozilla and Opera include scroll bar widths)
                        jQuery.browser.safari && window[ "inner" + name ] ||