Fixed memory leak in IE with non-native event types

[jquery.git] / src / event.js

diff --git a/src/event.js b/src/event.js
index b27b418..30f1b03 100644 (file)
--- a/src/event.js
+++ b/src/event.js
@@ -49,10 +49,14 @@ jQuery.event = {
                                if ( typeof jQuery == "undefined" || jQuery.event.triggered )
                                        return val;
                
-                               val = jQuery.event.handle.apply(elem, arguments);
+                               val = jQuery.event.handle.apply(arguments.callee.elem, arguments);
                
                                return val;
                        });
+               // Add elem as a property of the handle function
+               // This is to prevent a memory leak with non-native
+               // event in IE.
+               handle.elem = elem;
                        
                        // Handle multiple events seperated by a space
                        // jQuery(...).bind("mouseover mouseout", fn);
@@ -87,6 +91,9 @@ jQuery.event = {
                                // Keep track of which events have been used, for global triggering
                                jQuery.event.global[type] = true;
                        });
+               
+               // Nullify elem to prevent memory leaks in IE
+               elem = null;
        },
 
        guid: 1,
@@ -102,7 +109,7 @@ jQuery.event = {
 
                if ( events ) {
                        // Unbind all events for the element
-                       if ( !types )
+                       if ( types == undefined )
                                for ( var type in events )
                                        this.remove( elem, type );
                        else {
@@ -150,6 +157,8 @@ jQuery.event = {
                        // Remove the expando if it's no longer used
                        for ( ret in events ) break;
                        if ( !ret ) {
+                               var handle = jQuery.data( elem, "handle" );
+                               if ( handle ) handle.elem = null;
                                jQuery.removeData( elem, "events" );
                                jQuery.removeData( elem, "handle" );
                        }
@@ -196,7 +205,7 @@ jQuery.event = {
                                data.shift();
 
                        // Handle triggering of extra function
-                       if ( extra ) {
+                       if ( extra && jQuery.isFunction( extra ) ) {
                                // call the extra function and tack the current return value on the end for possible inspection
                                var ret = extra.apply( elem, data.concat( val ) );
                                // if anything is returned, give it precedence and have it overwrite the previous value
@@ -471,7 +480,7 @@ jQuery.extend({
                        }
                
                        // Trigger any bound ready events
-                       $(document).triggerHandler("ready");
+                       jQuery(document).triggerHandler("ready");
                }
        }
 });
@@ -482,27 +491,58 @@ function bindReady(){
        if ( readyBound ) return;
        readyBound = true;
 
-       // Mozilla, Opera and webkit nightlies currently support this event
-       if ( document.addEventListener )
+       // Mozilla, Opera (see further below for it) and webkit nightlies currently support this event
+       if ( document.addEventListener && !jQuery.browser.opera)
                // Use the handy event callback
                document.addEventListener( "DOMContentLoaded", jQuery.ready, false );
        
-       // If Safari or IE is used
+       // If IE is used and is not in a frame
        // Continually check to see if the document is ready
-       if (jQuery.browser.msie || jQuery.browser.safari ) (function(){
+       if ( jQuery.browser.msie && window == top ) (function(){
+               if (jQuery.isReady) return;
                try {
                        // If IE is used, use the trick by Diego Perini
                        // http://javascript.nwbox.com/IEContentLoaded/
-                       if ( jQuery.browser.msie || document.readyState != "loaded" && document.readyState != "complete" )
-                               document.documentElement.doScroll("left");
+                       document.documentElement.doScroll("left");
                } catch( error ) {
-                       return setTimeout( arguments.callee, 0 );
+                       setTimeout( arguments.callee, 0 );
+                       return;
                }
-
                // and execute any waiting functions
                jQuery.ready();
        })();
 
+       if ( jQuery.browser.opera )
+               document.addEventListener( "DOMContentLoaded", function () {
+                       if (jQuery.isReady) return;
+                       for (var i = 0; i < document.styleSheets.length; i++)
+                               if (document.styleSheets[i].disabled) {
+                                       setTimeout( arguments.callee, 0 );
+                                       return;
+                               }
+                       // and execute any waiting functions
+                       jQuery.ready();
+               }, false);
+
+       if ( jQuery.browser.safari ) {
+               var numStyles;
+               (function(){
+                       if (jQuery.isReady) return;
+                       if ( document.readyState != "loaded" && document.readyState != "complete" ) {
+                               setTimeout( arguments.callee, 0 );
+                               return;
+                       }
+                       if ( numStyles === undefined )
+                               numStyles = jQuery("style, link[rel=stylesheet]").length;
+                       if ( document.styleSheets.length != numStyles ) {
+                               setTimeout( arguments.callee, 0 );
+                               return;
+                       }
+                       // and execute any waiting functions
+                       jQuery.ready();
+               })();
+       }
+
        // A fallback to window.onload, that will always work
        jQuery.event.add( window, "load", jQuery.ready );
 }