Fixed bug #180 as suggested, changing xxx.constructor == Function to typeof xxx ...

[jquery.git] / src / jquery / jquery.js

diff --git a/src/jquery/jquery.js b/src/jquery/jquery.js
index 0b6b1f4..9f2189e 100644 (file)
--- a/src/jquery/jquery.js
+++ b/src/jquery/jquery.js
@@ -31,7 +31,7 @@ window.undefined = window.undefined;
 jQuery = function(a,c) {
 
        // Shortcut for document ready (because $(document).each() is silly)
-       if ( a && a.constructor == Function && jQuery.fn.ready )
+       if ( a && typeof a == "function" && jQuery.fn.ready )
                return jQuery(document).ready(a);
 
        // Make sure that a selection was provided
@@ -65,7 +65,7 @@ jQuery = function(a,c) {
        var fn = arguments[ arguments.length - 1 ];
 
        // If so, execute it in context
-       if ( fn && fn.constructor == Function )
+       if ( fn && typeof fn == "function" )
                this.each(fn);
 };
 
@@ -667,6 +667,12 @@ jQuery.fn = jQuery.prototype = {
         * var result = $('#first').append('<b>buga</b>');
         * ok( result.text() == defaultText + 'buga', 'Check if text appending works' );
         *
+        * @test reset();
+        * var expected = "Try them out: bla ";
+        * $('#first').append(" ");
+        * $('#first').append("bla ");
+        * ok( expected == $('#first').text(), "Check for appending of spaces" );
+        *
         * @name append
         * @type jQuery
         * @param String html A string of HTML, that will be created on the fly and appended to the target.
@@ -1013,7 +1019,7 @@ jQuery.fn = jQuery.prototype = {
                        t.constructor == Boolean &&
                        ( t ? this.get() : [] ) ||
 
-                       t.constructor == Function &&
+                       typeof t == "function" &&
                        jQuery.grep( this, t ) ||
 
                        jQuery.filter(t,this).r, arguments );
@@ -1208,7 +1214,7 @@ jQuery.fn = jQuery.prototype = {
                } else {
                        var old = this.get();
                        this.get( a );
-                       if ( fn.constructor == Function )
+                       if ( typeof fn == "function" )
                                this.each( fn );
                        this.get( old );
                }
@@ -1367,9 +1373,22 @@ jQuery.extend({
                        o.className += ( o.className ? " " : "" ) + c;
                },
                remove: function(o,c){
+                       /*
                        o.className = !c ? "" :
                                o.className.replace(
-                                       new RegExp("(^|\\s*\\b[^-])"+c+"($|\\b(?=[^-]))", "g"), "");
+                                       new RegExp("(^|\\s*\\b[^-])"+c+"($|\\b(?=[^-]))", "g"), "");*/
+                       if( !c ) {
+                               o.className = "";
+                       } else {
+                               var classes = o.className.split(" ");
+                               for(var i=0; i<classes.length; i++) {
+                                       if(classes[i] == c) {
+                                               classes.splice(i, 1);
+                                               break;
+                                       }
+                               }
+                               o.className = classes.join(' ');
+                       }
                },
                has: function(e,a) {
                        if ( e.className != undefined )
@@ -1678,6 +1697,9 @@ jQuery.extend({
         * @test t( "Form element :radio", ":radio", ["radio1", "radio2"] );
         * @test t( "Form element :checkbox", ":checkbox", ["check1", "check2"] );
         * @test t( "Form element :text", ":text", ["text1", "text2", "hidden2", "name"] );
+        * @test t( "Form element :radio:checked", ":radio:checked", ["radio2"] );
+        * @test t( "Form element :checkbox:checked", ":checkbox:checked", ["check1"] );
+        * @test t( "Form element :checkbox:checked, :radio:checked", ":checkbox:checked, :radio:checked", ["check1", "radio2"] );
         *
         * @test t( ":not() Existing attribute", "input:not([@name])", ["text2", "check2"]);
         * @test t( ":not() Equals attribute", "select:not([@name=select1])", ["select2", "select3"]);
@@ -2673,6 +2695,10 @@ jQuery.macros = {
                 * @before <input type="text" id="test" value="some text"/>
                 * @result "test"
                 *
+                * @test ok( $(document.getElementById('main')).id() == "main", "Check for id" );
+                * @test ok( $("#foo").id() == "foo", "Check for id" );
+                * @test ok( !$("head").id(), "Check for id" );
+                *
                 * @name id
                 * @type String
                 * @cat DOM/Attributes
@@ -2699,6 +2725,9 @@ jQuery.macros = {
                 * @before <img src="test.jpg" title="my image"/>
                 * @result "my image"
                 *
+                * @test ok( $(document.getElementById('google')).title() == "Google!", "Check for title" );
+                * @test ok( !$("#yahoo").title(), "Check for title" );
+                *
                 * @name title
                 * @type String
                 * @cat DOM/Attributes
@@ -2725,6 +2754,10 @@ jQuery.macros = {
                 * @before <input type="text" name="username"/>
                 * @result "username"
                 *
+                * @test ok( $(document.getElementById('text1')).name() == "action", "Check for name" );
+                * @test ok( $("#hidden1").name() == "hidden", "Check for name" );
+                * @test ok( !$("#area1").name(), "Check for name" );
+                *
                 * @name name
                 * @type String
                 * @cat DOM/Attributes
@@ -3014,6 +3047,8 @@ jQuery.macros = {
                 * @before <p>Hello</p><div><span>Hello Again</span></div><p>And Again</p>
                 * @result [ <span>Hello Again</span> ]
                 *
+                * @test isSet( $("#foo").children().get(), q("sndp", "en", "sap"), "Check for children" );
+                *
                 * @name children
                 * @type jQuery
                 * @cat DOM/Traversing
@@ -3027,6 +3062,8 @@ jQuery.macros = {
                 * @before <div><span>Hello</span><p class="selected">Hello Again</p><p>And Again</p></div>
                 * @result [ <p class="selected">Hello Again</p> ]
                 *
+                * @test isSet( $("#foo").children("[code]").get(), q("sndp", "sap"), "Check for filtered children" ); 
+                *
                 * @name children
                 * @type jQuery
                 * @param String expr An expression to filter the child Elements with
@@ -3156,6 +3193,14 @@ jQuery.macros = {
                 * }
                 * ok( pass, "Remove Class" );
                 *
+                * @test var div = $("div").addClass("test").addClass("foo").addClass("bar");
+                * div.removeClass("test").removeClass("bar").removeClass("foo");
+                * var pass = true;
+                * for ( var i = 0; i < div.size(); i++ ) {
+                *  if ( div.get(i).className.match(/test|bar|foo/) ) pass = false;
+                * }
+                * ok( pass, "Remove multiple classes" );
+                *
                 * @name removeClass
                 * @type jQuery
                 * @param String class A CSS class to remove from the elements