X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;ds=inline;f=src%2Fajax%2Fajax.js;h=1f01553f72cf90c4bf2854d33535ca873d39f4ff;hb=ad2a6bd91626efbaf9509c9643c60679b1fab942;hp=07d69b40dcac60336dfec64df603d46235b557f2;hpb=7dd456176d399a27784f22e58168ba9db95df8f5;p=jquery.git

diff --git a/src/ajax/ajax.js b/src/ajax/ajax.js
index 07d69b4..1f01553 100644
--- a/src/ajax/ajax.js
+++ b/src/ajax/ajax.js
@@ -95,8 +95,12 @@ jQuery.fn.extend({
 	},
 
 	/**
-	 * A function for serializing a set of input elements into
-	 * a string of data.
+	 * Serializes a set of input elements into a string of data.
+	 * This will serialize all given elements. If you need 
+	 * serialization similar to the form submit of a browser,
+	 * you should use the form plugin. This is also true for
+	 * selects with multiple attribute set, only a single option
+	 * is serialized.
 	 *
 	 * @example $("input[@type=text]").serialize();
 	 * @before <input type='text' name='name' value='John'/>
@@ -104,8 +108,9 @@ jQuery.fn.extend({
 	 * @after name=John&location=Boston
 	 * @desc Serialize a selection of input elements to a string
 	 *
-	 * @test var data = $(':input').serialize();
-	 * ok( data == 'action=Test&text2=Test&radio1=on&radio2=on&check=on&=on&hidden=&foo[bar]=&name=name&button=&=foobar&select1=&select2=3&select3=1', 'Check form serialization as query string' );
+	 * @test var data = $(':input').not('button').serialize();
+	 * // ignore button, IE takes text content as value, not relevant for this test
+	 * ok( data == 'action=Test&text2=Test&radio1=on&radio2=on&check=on&=on&hidden=&foo[bar]=&name=name&=foobar&select1=&select2=3&select3=1', 'Check form serialization as query string' );
 	 *
 	 * @name serialize
 	 * @type String
@@ -216,21 +221,26 @@ if ( jQuery.browser.msie && typeof XMLHttpRequest == "undefined" )
  *     ok( counter.error == 2, 'Check failed request' );
  *     ok( counter.success == 0, 'Check failed request' );
  *     ok( counter.complete == 3, 'Check failed request' );
- *     counter.error = 0; counter.success = 0; counter.complete = 0;
- *     $.ajaxTimeout(0);
- *     $.ajax({url: "data/name.php?wait=5", global: false, success: success, error: error, complete: function() {
- *       ok( counter.error == 0, 'Check sucesful request without globals' );
- *       ok( counter.success == 1, 'Check sucesful request without globals' );
- *       ok( counter.complete == 0, 'Check sucesful request without globals' );
- *       counter.error = 0; counter.success = 0; counter.complete = 0;
- *       $.ajaxTimeout(500);
- *       $.ajax({url: "data/name.php?wait=5", global: false, success: success, error: error, complete: function() {
- *         ok( counter.error == 1, 'Check failedrequest without globals' );
- *         ok( counter.success == 0, 'Check failed request without globals' );
- *         ok( counter.complete == 0, 'Check failed request without globals' );
- *         start();
- *       }});
- *     }});
+ *     start();
+ *   }});
+ * }});
+ 
+ * @test stop(); var counter = { complete: 0, success: 0, error: 0 };
+ * counter.error = 0; counter.success = 0; counter.complete = 0;
+ * var success = function() { counter.success++ };
+ * var error = function() { counter.error++ };
+ * $.ajaxTimeout(0);
+ * $.ajax({url: "data/name.php", global: false, success: success, error: error, complete: function() {
+ *   ok( counter.error == 0, 'Check sucesful request without globals' );
+ *   ok( counter.success == 1, 'Check sucesful request without globals' );
+ *   ok( counter.complete == 0, 'Check sucesful request without globals' );
+ *   counter.error = 0; counter.success = 0; counter.complete = 0;
+ *   $.ajaxTimeout(500);
+ *   $.ajax({url: "data/name.php?wait=5", global: false, success: success, error: error, complete: function() {
+ *      ok( counter.error == 1, 'Check failed request without globals' );
+ *      ok( counter.success == 0, 'Check failed request without globals' );
+ *      ok( counter.complete == 0, 'Check failed request without globals' );
+ *      start();
  *   }});
  * }});
  * 
@@ -298,7 +308,8 @@ jQuery.extend({
 			data = null;
 		}
 		
-		if ( data ) url += "?" + jQuery.param(data);
+		// append ? + data or & + data, in case there are already params
+		if ( data ) url += ((url.indexOf("?") > -1) ? "&" : "?") + jQuery.param(data);
 		
 		// Build and start the HTTP Request
 		jQuery.ajax( "GET", url, null, function(r, status) {
@@ -476,6 +487,7 @@ jQuery.extend({
 	 * 	if(passed == 2) {
 	 * 		ok( true, 'Check local and global callbacks after timeout' );
 	 * 		clearTimeout(timeout);
+	 *      $('#main').unbind("ajaxError");
 	 * 		start();
 	 * 	}
 	 * };
@@ -492,6 +504,24 @@ jQuery.extend({
 	 *   success: fail
 	 * });
 	 *
+	 * @test stop(); $.ajaxTimeout(50);
+	 * $.ajax({
+	 *   type: "GET",
+	 *   timeout: 5000,
+	 *   url: "data/name.php?wait=1",
+	 *   error: function() {
+	 * 	   ok( false, 'Check for local timeout failed' );
+	 * 	   start();
+	 *   },
+	 *   success: function() {
+	 *     ok( true, 'Check for local timeout' );
+	 *     start();
+	 *   }
+	 * });
+	 * // reset timeout
+	 * $.ajaxTimeout(0);
+	 * 
+	 *
 	 * @name $.ajaxTimeout
 	 * @type jQuery
 	 * @param Number time How long before an AJAX request times out.
@@ -520,6 +550,14 @@ jQuery.extend({
 	 * (String) dataType - The type of data that you're expecting back from
 	 * the server (e.g. "xml", "html", "script", or "json").
 	 *
+	 * (Boolean) ifModified - Allow the request to be successful only if the
+	 * response has changed since the last request, default is false, ignoring
+	 * the Last-Modified header
+	 *
+	 * (Number) timeout - Local timeout to override global timeout, eg. to give a
+	 * single request a longer timeout while all others timeout after 1 seconds,
+	 * see $.ajaxTimeout
+	 *
 	 * (Boolean) global - Wheather to trigger global AJAX event handlers for
 	 * this request, default is true. Set to true to prevent that global handlers
 	 * like ajaxStart or ajaxStop are triggered.
@@ -588,6 +626,8 @@ jQuery.extend({
 			var error = type.error;
 			var dataType = type.dataType;
 			var global = typeof type.global == "boolean" ? type.global : true;
+			var timeout = typeof type.timeout == "number" ? type.timeout : jQuery.timeout;
+			var ifModified = type.ifModified || false;
 			data = type.data;
 			url = type.url;
 			type = type.type;
@@ -633,8 +673,13 @@ jQuery.extend({
 				// Make sure that the request was successful or notmodified
 				if ( status != "error" ) {
 					// Cache Last-Modified header, if ifModified mode.
-					var modRes = xml.getResponseHeader("Last-Modified");
-					if ( ifModified && modRes ) jQuery.lastModified[url] = modRes;
+					var modRes;
+					try {
+						modRes = xml.getResponseHeader("Last-Modified");
+					} catch(e) {} // swallow exception thrown by FF if header is not available
+					
+					if ( ifModified && modRes )
+						jQuery.lastModified[url] = modRes;
 					
 					// If a local callback was specified, fire it
 					if ( success )
@@ -674,7 +719,7 @@ jQuery.extend({
 		xml.onreadystatechange = onreadystatechange;
 		
 		// Timeout checker
-		if(jQuery.timeout > 0)
+		if(timeout > 0)
 			setTimeout(function(){
 				// Check to see if the request is still happening
 				if (xml) {
@@ -686,7 +731,7 @@ jQuery.extend({
 					// Clear from memory
 					xml = null;
 				}
-			}, jQuery.timeout);
+			}, timeout);
 		
 		// Send the data
 		xml.send(data);