X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=lib%2Fas3%2Fcode.c;h=e1ccba8932ca00a041d1b1d773d473dc497fa913;hb=7ea066e4193b0c1c75427bdabafe5c8b0e19e4be;hp=aef16ed5398569ae36a88ef2ed395e3f377ef7e1;hpb=75d341a689529da3879676403e43667008ac5820;p=swftools.git

diff --git a/lib/as3/code.c b/lib/as3/code.c
index aef16ed..e1ccba8 100644
--- a/lib/as3/code.c
+++ b/lib/as3/code.c
@@ -37,6 +37,7 @@
 #define OP_LOOKUPSWITCH 512
 #define OP_NEED_ACTIVATION 1024
 #define OP_STACK_ARGS2 2048
+#define OP_INTERNAL 32768
 
 /* 2 = u30 index into multiname
    m = u30 index into method
@@ -199,9 +200,10 @@ opcode_t opcodes[]={
 //0x53: seen in builtin.abc
 {0x53, "applytype", "n",       -1, 1, 0, OP_STACK_ARGS},
 
-/* dummy instruction. Warning: this one is not actually supported by flash */
-{0xfe, "__continue__", "s",           0, 0, 0, OP_RETURN},
-{0xff, "__break__", "s",            0, 0, 0, OP_RETURN},
+/* dummy instructions. Warning: these are not actually supported by flash */
+{0xfd, "__fallthrough__", "s",           0, 0, 0, OP_INTERNAL},
+{0xfe, "__continue__", "s",           0, 0, 0, OP_RETURN|OP_INTERNAL},
+{0xff, "__break__", "s",            0, 0, 0, OP_RETURN|OP_INTERNAL},
 };
 
 static U8 op2index[256] = {254};
@@ -459,6 +461,15 @@ static int opcode_write(TAG*tag, code_t*c, pool_t*pool, abc_file_t*file, int len
         swf_SetU8(tag, c->opcode);
     len++;
 
+    if(op->flags & OP_INTERNAL) {
+        if(c->opcode == OPCODE___BREAK__ ||
+           c->opcode == OPCODE___CONTINUE__) {
+            fprintf(stderr, "Unresolved %s\n", op->name);
+        } else {
+            fprintf(stderr, "Error: writing undefined internal opcode %s\n", op->name);
+        }
+    }
+
     while(*p) {
         void*data = c->data[pos++];
         assert(pos<=2);
@@ -901,7 +912,7 @@ int code_dump(code_t*c, abc_exception_list_t*exceptions, abc_file_t*file, char*p
                     free(m);
                 } else if(*p == 'm') {
                     abc_method_t*m = (abc_method_t*)data;
-                    fprintf(fo, "[method %s]", m->name);
+                    fprintf(fo, "[method %08x %s]", m, m->name);
                 } else if(*p == 'c') {
                     abc_class_t*cls = (abc_class_t*)data;
                     char*classname = multiname_tostring(cls->classname);
@@ -1102,16 +1113,26 @@ code_t*code_dup(code_t*c)
     return last;
 }
 
-code_t*code_cutlast(code_t*c)
+code_t*code_cut(code_t*c)
 {
     if(!c) return c;
-    assert(!c->next);
     code_t*prev = c->prev;
+    code_t*next = c->next;
     c->prev = 0;
-    if(prev)
-        prev->next=0;
+    c->next = 0;
+    if(prev) prev->next=next;
+    if(next) next->prev=prev;
     code_free(c);
-    return prev;
+    
+    if(next) return code_end(next);
+    else     return prev;
+}
+
+code_t*code_cutlast(code_t*c)
+{
+    if(!c) return c;
+    assert(!c->next);
+    return code_cut(c);
 }
 
 code_t* cut_last_push(code_t*c)
@@ -1143,8 +1164,19 @@ code_t* cut_last_push(code_t*c)
         } else if(c->opcode == OPCODE_CALLSUPER) {
             c->opcode = OPCODE_CALLSUPERVOID;
             return c;
-        }
-        else
+        } else if(c->opcode == OPCODE_NEWOBJECT ||
+                  c->opcode == OPCODE_NEWARRAY) {
+            // we can discard these if they're not eating up stack parameters
+            if(!c->data[0])
+                return code_cutlast(c);
+        } else if(op->stack_minus ==0 && op->stack_plus == 0 && 
+                !(op->flags&~(OP_REGISTER|OP_SET_DXNS)) && c->prev) {
+            // trim code *before* the kill, inclocal, declocal, dxns
+            code_t*p = c->prev; 
+            p->next = 0;
+            c->prev = 0;
+            return code_append(cut_last_push(p), c);
+        } else
             break;
     }
     c = abc_pop(c);