X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=lib%2Fdevices%2Fpolyops.c;h=fa0b7f406977ccb6ca00af2ab4a35f331df832b9;hb=e4687b3aa2aed49fb16ba9e9561344d808750297;hp=b4c2a0bb4ee61b06bb38bcbd82baf641d7f9d367;hpb=41f844437efe51f7106c03889f56c2ca637d02f0;p=swftools.git

diff --git a/lib/devices/polyops.c b/lib/devices/polyops.c
index b4c2a0b..fa0b7f4 100644
--- a/lib/devices/polyops.c
+++ b/lib/devices/polyops.c
@@ -45,6 +45,9 @@ typedef struct _internal {
     gfxdevice_t*out;
     clip_t*clip;
     gfxpoly_t*polyunion;
+    
+    int good_polygons;
+    int bad_polygons;
 } internal_t;
 
 static int verbose = 0;
@@ -57,7 +60,7 @@ static void dbg(char*format, ...)
     int l;
     va_list arglist;
     va_start(arglist, format);
-    vsprintf(buf, format, arglist);
+    vsnprintf(buf, sizeof(buf)-1, format, arglist);
     va_end(arglist);
     l = strlen(buf);
     while(l && buf[l-1]=='\n') {
@@ -90,6 +93,11 @@ void polyops_startclip(struct _gfxdevice*dev, gfxline_t*line)
 
     gfxpoly_t* oldclip = i->clip?i->clip->poly:0;
     gfxpoly_t* poly = gfxpoly_fillToPoly(line);
+    if(poly) 
+        i->good_polygons++;
+    else
+        i->bad_polygons++;
+
     gfxpoly_t* currentclip = 0;
     int type = 0;
 
@@ -97,7 +105,7 @@ void polyops_startclip(struct _gfxdevice*dev, gfxline_t*line)
        a gfxline into a gfxpoly- for polygons which are too
        complex or just degenerate, this might fail. So handle
        all the cases where polygon conversion or intersection
-       might fail */
+       might go awry */
     if(!poly && !oldclip) {
 	i->out->startclip(i->out,line);
 	currentclip = 0;
@@ -111,11 +119,13 @@ void polyops_startclip(struct _gfxdevice*dev, gfxline_t*line)
     } else if(poly && oldclip) {
 	gfxpoly_t*intersection = gfxpoly_intersect(poly, oldclip);
 	if(intersection) {
+            i->good_polygons++;
 	    // this case is what usually happens 
 	    gfxpoly_free(poly);poly=0;
 	    currentclip = intersection;
 	    type = 0;
 	} else {
+            i->bad_polygons++;
 	    gfxline_t*oldclipline = gfxpoly_to_gfxline(oldclip);
 	    i->out->startclip(i->out, oldclipline);
 	    currentclip = poly;
@@ -166,7 +176,7 @@ static void addtounion(struct _gfxdevice*dev, gfxpoly_t*poly)
     }
 }
 
-gfxline_t* handle_poly(gfxdevice_t*dev, gfxpoly_t*poly)
+static gfxline_t* handle_poly(gfxdevice_t*dev, gfxpoly_t*poly, char*ok)
 {
     internal_t*i = (internal_t*)dev->internal;
     if(i->clip && i->clip->poly) {
@@ -176,12 +186,19 @@ gfxline_t* handle_poly(gfxdevice_t*dev, gfxpoly_t*poly)
 	    gfxpoly_free(old);
 	}
     }
+
+    if(poly) 
+        i->good_polygons++;
+    else
+        i->bad_polygons++;
+
     addtounion(dev, poly);
     gfxline_t*gfxline = 0;
     if(poly) {
 	// this is the case where everything went right
 	gfxline_t*line = gfxpoly_to_gfxline(poly);
 	gfxpoly_free(poly);
+        *ok = 1;
 	return line;
     } else {
 	if(i->clip && i->clip->poly) {
@@ -206,12 +223,14 @@ void polyops_stroke(struct _gfxdevice*dev, gfxline_t*line, gfxcoord_t width, gfx
     internal_t*i = (internal_t*)dev->internal;
 
     gfxpoly_t* poly = gfxpoly_strokeToPoly(line, width, cap_style, joint_style, miterLimit);
-    gfxline_t*line2 = handle_poly(dev, poly);
+    char ok = 0;
+    gfxline_t*line2 = handle_poly(dev, poly, &ok);
 
-    if(line2) {
-	if(i->out) i->out->fill(i->out, line2, color);
+    if(ok) {
+	if(i->out && line2) i->out->fill(i->out, line2, color);
 	gfxline_free(line2);
     } else {
+        msg("<error> ..");
 	if(i->out) i->out->stroke(i->out, line, width, color, cap_style, joint_style, miterLimit);
     }
 }
@@ -222,10 +241,11 @@ void polyops_fill(struct _gfxdevice*dev, gfxline_t*line, gfxcolor_t*color)
     internal_t*i = (internal_t*)dev->internal;
 
     gfxpoly_t*poly = gfxpoly_fillToPoly(line);
-    gfxline_t*line2 = handle_poly(dev, poly);
+    char ok = 0;
+    gfxline_t*line2 = handle_poly(dev, poly, &ok);
 
-    if(line2) {
-	if(i->out) i->out->fill(i->out, line2, color);
+    if(ok) {
+	if(i->out && line2) i->out->fill(i->out, line2, color);
 	gfxline_free(line2);
     } else {
 	if(i->out) i->out->fill(i->out, line, color);
@@ -238,10 +258,11 @@ void polyops_fillbitmap(struct _gfxdevice*dev, gfxline_t*line, gfximage_t*img, g
     internal_t*i = (internal_t*)dev->internal;
     
     gfxpoly_t*poly = gfxpoly_fillToPoly(line);
-    gfxline_t*line2 = handle_poly(dev, poly);
+    char ok = 0;
+    gfxline_t*line2 = handle_poly(dev, poly, &ok);
 
-    if(line2) {
-	if(i->out) i->out->fillbitmap(i->out, line2, img, matrix, cxform);
+    if(ok) {
+	if(i->out && line2) i->out->fillbitmap(i->out, line2, img, matrix, cxform);
 	gfxline_free(line2);
     } else {
 	if(i->out) i->out->fillbitmap(i->out, line, img, matrix, cxform);
@@ -254,10 +275,11 @@ void polyops_fillgradient(struct _gfxdevice*dev, gfxline_t*line, gfxgradient_t*g
     internal_t*i = (internal_t*)dev->internal;
     
     gfxpoly_t*poly = gfxpoly_fillToPoly(line);
-    gfxline_t*line2 = handle_poly(dev, poly);
+    char ok = 0;
+    gfxline_t*line2 = handle_poly(dev, poly, &ok);
 
-    if(line2) {
-	if(i->out) i->out->fillgradient(i->out, line2, gradient, type, matrix);
+    if(ok) {
+	if(i->out && line2) i->out->fillgradient(i->out, line2, gradient, type, matrix);
 	gfxline_free(line2);
     } else {
 	if(i->out) i->out->fillgradient(i->out, line, gradient, type, matrix);
@@ -284,8 +306,9 @@ void polyops_drawchar(struct _gfxdevice*dev, gfxfont_t*font, int glyphnr, gfxcol
 	gfxbbox_t bbox = gfxline_getbbox(glyph);
 	gfxpoly_t*dummybox = gfxpoly_createbox(bbox.xmin,bbox.ymin,bbox.xmax,bbox.ymax);
 
-	gfxline_t*gfxline = handle_poly(dev, dummybox);
-	if(gfxline) {
+        char ok=0;
+	gfxline_t*gfxline = handle_poly(dev, dummybox, &ok);
+	if(ok) {
 	    gfxbbox_t bbox2 = gfxline_getbbox(gfxline);
 	    double w = bbox2.xmax - bbox2.xmin;
 	    double h = bbox2.ymax - bbox2.ymin;
@@ -328,8 +351,13 @@ gfxresult_t* polyops_finish(struct _gfxdevice*dev)
     dbg("polyops_finish");
     internal_t*i = (internal_t*)dev->internal;
 
+
     if(i->polyunion) {
 	gfxpoly_free(i->polyunion);i->polyunion=0;
+    } else {
+        if(i->bad_polygons) {
+            msg("<notice> --flatten success rate: %.1f%% (%d failed polygons)", i->good_polygons*100.0 / (i->good_polygons + i->bad_polygons), i->bad_polygons);
+        }
     }
     if(i->out) {
 	return i->out->finish(i->out);