X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=lib%2Fpython%2Ftaglist.c;h=7e101c8457f01e0fa400766c958a69530ce896f2;hb=9817ae42f3b01b7e00612f5089664b98d2b788c5;hp=e4eeffc2bb39aea5c5bd008638a83717b53fc6b0;hpb=a6d5a31e91e224064e105b5383ebbdce79060997;p=swftools.git diff --git a/lib/python/taglist.c b/lib/python/taglist.c index e4eeffc..7e101c8 100644 --- a/lib/python/taglist.c +++ b/lib/python/taglist.c @@ -13,14 +13,12 @@ typedef struct { PyObject_HEAD PyObject* taglist; - PyObject* tagmap; } TagListObject; //---------------------------------------------------------------------------- PyObject * taglist_new() { TagListObject* taglist = PyObject_New(TagListObject, &TagListClass); mylog("+%08x(%d) taglist_new", (int)taglist, taglist->ob_refcnt); - taglist->tagmap = tagmap_new(); taglist->taglist = PyList_New(0); return (PyObject*)taglist; } @@ -29,36 +27,45 @@ PyObject * taglist_new2(TAG*tag) { TagListObject* taglist = PyObject_New(TagListObject, &TagListClass); mylog("+%08x(%d) taglist_new2 tag=%08x", (int)taglist, taglist->ob_refcnt, tag); - taglist->tagmap = tagmap_new(); + PyObject* tagmap = tagmap_new(); - int nr=0; + int nr=0, len=0; TAG*t = tag; - while(t) {nr++;t=t->next;} - taglist->taglist = PyList_New(nr); - - mylog("+%08x(%d) taglist_new2: %d items", (int)taglist, taglist->ob_refcnt, nr); + TAG*last = t; + while(t) {len++;last=t;t=t->next;} + + if(last && last->id==ST_END) { + swf_DeleteTag(last); last = 0; + len--; + if(len==0) tag = 0; + } + taglist->taglist = PyList_New(len); + nr = 0; t = tag; while(t) { - PyObject*newtag = tag_new2(t, taglist->tagmap); + PyObject*newtag = tag_new2(t, tagmap); if(newtag==NULL) { // pass through exception + Py_DECREF(tagmap); return NULL; } PyList_SET_ITEM(taglist->taglist,nr,newtag);Py_INCREF(newtag); if(swf_isDefiningTag(t)) { int id = swf_GetDefineID(t); - tagmap_addMapping(taglist->tagmap, id, newtag); + tagmap_addMapping(tagmap, id, newtag); } nr++; t=t->next; } + Py_DECREF(tagmap); return (PyObject*)taglist; } //---------------------------------------------------------------------------- TAG* taglist_getTAGs(PyObject*self) { + PyObject* tagmap = tagmap_new(); if(!PY_CHECK_TYPE(self,&TagListClass)) { PyErr_SetString(PyExc_Exception, setError("Not a taglist (%08x).", self)); return 0; @@ -74,11 +81,16 @@ TAG* taglist_getTAGs(PyObject*self) mylog(" %08x(%d) taglist_getTAGs", (int)self, self->ob_refcnt); for(t=0;ttaglist, t); - tag = tag_getTAG(item, tag, taglist->tagmap); + tag = tag_getTAG(item, tag, tagmap); + if(!tag) { + //pass through errors + Py_DECREF(tagmap); + return 0; + } if(!firstTag) firstTag = tag; - mylog(" %08x(%d) taglist_getTAGs: added tag %08x", (int)self, self->ob_refcnt, tag); } + Py_DECREF(tagmap); return firstTag; } //---------------------------------------------------------------------------- @@ -127,11 +139,9 @@ static PyObject * taglist_optimizeOrder(PyObject* self, PyObject* args) static void taglist_dealloc(PyObject* self) { TagListObject*taglist = (TagListObject*)self; - mylog("-%08x(%d) taglist_dealloc\n", (int)self, self->ob_refcnt); + mylog("-%08x(%d) taglist_dealloc list=%08x(%d)\n", (int)self, self->ob_refcnt, taglist->taglist, taglist->taglist->ob_refcnt); Py_DECREF(taglist->taglist); taglist->taglist = 0; - Py_DECREF(taglist->tagmap); - taglist->tagmap= 0; PyObject_Del(self); } //---------------------------------------------------------------------------- @@ -158,7 +168,7 @@ static int taglist_length(PyObject * self) //---------------------------------------------------------------------------- static int taglist_contains(PyObject * self, PyObject * tag) { - mylog(" %08x(%d) taglist_contains %08x", (int)self, self->ob_refcnt, tag); + /* TODO: optimize! */ TagListObject*taglist = (TagListObject*)self; PyObject*list = taglist->taglist; int l = PyList_Size(list); @@ -166,11 +176,9 @@ static int taglist_contains(PyObject * self, PyObject * tag) for(t=0;tob_refcnt); return 1; } } - mylog(" %08x(%d) taglist_contains: no", (int)self, self->ob_refcnt); return 0; } //---------------------------------------------------------------------------- @@ -179,14 +187,12 @@ static PyObject * taglist_concat(PyObject * self, PyObject* list) PyObject*tag = 0; PY_ASSERT_TYPE(self, &TagListClass); TagListObject*taglist = (TagListObject*)self; - mylog(" %08x(%d) taglist_concat %08x", (int)self, self->ob_refcnt, list); + mylog(" %08x(%d) taglist_concat %08x(%d)", (int)self, self->ob_refcnt, list, list->ob_refcnt); if (PyArg_Parse(list, "O!", &TagClass, &tag)) { - mylog(" %08x(%d) taglist_concat: Tag %08x", (int)self, self->ob_refcnt, tag); list = tag_getDependencies(tag); int l = PyList_Size(list); int t; - mylog(" %08x(%d) taglist_concat: Tag: %d dependencies", (int)self, self->ob_refcnt, l); for(t=0;tob_refcnt, tag); + mylog(" %08x(%d) taglist_concat: Adding Tag %08x(%d)", (int)self, self->ob_refcnt, tag, tag->ob_refcnt); PyList_Append(taglist->taglist, tag); + } else { + mylog(" %08x(%d) taglist_concat: Already contains Tag %08x(%d)", (int)self, self->ob_refcnt, tag, tag->ob_refcnt); } - mylog(" %08x(%d) taglist_concat: done", (int)self, self->ob_refcnt); Py_INCREF(self); return self; /* copy tag, so we don't have to do INCREF(tag) (and don't @@ -227,7 +234,6 @@ static PyObject * taglist_concat(PyObject * self, PyObject* list) if (PyList_Check(list)) { int l = PyList_Size(list); int t; - mylog(" %08x(%d) taglist_concat: List", (int)self, self->ob_refcnt); for(t=0;tob_refcnt); TagListObject*taglist2 = (TagListObject*)list; return taglist_concat(self, taglist2->taglist); @@ -269,7 +274,7 @@ static PyObject * taglist_item(PyObject * self, int index) PyObject*tag; mylog(" %08x(%d) taglist_item(%d)", (int)self, self->ob_refcnt, index); tag = PyList_GetItem(taglist->taglist, index); - Py_INCREF(tag); //TODO-REF + Py_INCREF(tag); return tag; } static PySequenceMethods taglist_as_sequence = @@ -283,7 +288,7 @@ static PySequenceMethods taglist_as_sequence = sq_ass_slice: 0, // x[i:j] = v intintobjargproc sq_contains: taglist_contains, //??? }; -static PyTypeObject TagListClass = +PyTypeObject TagListClass = { PyObject_HEAD_INIT(NULL) 0,