X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=src%2Fattributes.js;h=4f5692f577b1055984f6266c6bf41f927802f5ba;hb=61e37d41490aed319a176c6ca7feb95e5505059c;hp=050978110568fd9d8b649a5e93d2f99a3cacc58c;hpb=f0366306923ecf97b487032d61c2fcc2b4b068c4;p=jquery.git diff --git a/src/attributes.js b/src/attributes.js index 0509781..4f5692f 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -142,7 +142,7 @@ jQuery.fn.extend({ var val = value; - return this.each(function(){ + return this.each(function() { if ( jQuery.isFunction(value) ) { val = value.call(this); @@ -163,7 +163,7 @@ jQuery.fn.extend({ } else if ( jQuery.nodeName( this, "select" ) ) { var values = jQuery.makeArray(val); - jQuery( "option", this ).each(function(){ + jQuery( "option", this ).each(function() { this.selected = jQuery.inArray( this.value || this.text, values ) >= 0; }); @@ -210,10 +210,12 @@ jQuery.each({ this.className = this.className || classNames === false ? "" : jQuery.data( this, "__className__" ) || ""; } } -}, function(name, fn){ - jQuery.fn[ name ] = function(val, state){ +}, function( name, fn ) { + jQuery.fn[ name ] = function( val, state ) { if ( jQuery.isFunction( val ) ) { - return this.each(function() { jQuery(this)[ name ]( val.call(this), state ); }); + return this.each(function() { + jQuery(this)[ name ]( val.call(this), state ); + }); } return this.each( fn, arguments ); @@ -232,13 +234,13 @@ jQuery.extend({ offset: true }, - attr: function( elem, name, value ) { + attr: function( elem, name, value, pass ) { // don't set attributes on text and comment nodes if ( !elem || elem.nodeType === 3 || elem.nodeType === 8 ) { return undefined; } - if ( name in jQuery.attrFn && value !== undefined ) { + if ( pass && name in jQuery.attrFn ) { return jQuery(elem)[name](value); } @@ -268,14 +270,7 @@ jQuery.extend({ throw "type property can't be changed"; } - // browsers index elements by id/name on forms, give priority to attributes. - if( jQuery.nodeName( elem, "form" ) ) { - // convert the value to a string (all browsers do this but IE) see #1070 - elem.setAttribute( name, "" + value ); - - } else { - elem[ name ] = value; - } + elem[ name ] = value; } // browsers index elements by id/name on forms, give priority to attributes.