X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=src%2Feffects.js;h=56141bb29a783cc6f9fa1dbf6f25bec7e3f999b5;hb=cb811c04b035eb2d652b0831e20ea1d3a4d9c448;hp=9db341a3b077f491708af2095522ac25b6a9c81d;hpb=77e310b906112c9e20dfbf0e91249a0b81cf6107;p=jquery.git diff --git a/src/effects.js b/src/effects.js index 9db341a..56141bb 100644 --- a/src/effects.js +++ b/src/effects.js @@ -1,7 +1,7 @@ (function( jQuery ) { var elemdisplay = {}, - rfxtypes = /toggle|show|hide/, + rfxtypes = /^(?:toggle|show|hide)$/, rfxnum = /^([+\-]=)?([\d+.\-]+)(.*)$/, timerId, fxAttrs = [ @@ -14,9 +14,9 @@ var elemdisplay = {}, ]; jQuery.fn.extend({ - show: function( speed, callback ) { + show: function( speed, easing, callback ) { if ( speed || speed === 0) { - return this.animate( genFx("show", 3), speed, callback); + return this.animate( genFx("show", 3), speed, easing, callback); } else { for ( var i = 0, l = this.length; i < l; i++ ) { @@ -31,7 +31,7 @@ jQuery.fn.extend({ display = elemdisplay[ nodeName ]; } else { - var elem = jQuery("<" + nodeName + " />").appendTo("body"); + var elem = jQuery("<" + nodeName + ">").appendTo("body"); display = elem.css("display"); @@ -58,9 +58,9 @@ jQuery.fn.extend({ } }, - hide: function( speed, callback ) { + hide: function( speed, easing, callback ) { if ( speed || speed === 0 ) { - return this.animate( genFx("hide", 3), speed, callback); + return this.animate( genFx("hide", 3), speed, easing, callback); } else { for ( var i = 0, l = this.length; i < l; i++ ) { @@ -83,7 +83,7 @@ jQuery.fn.extend({ // Save the old toggle function _toggle: jQuery.fn.toggle, - toggle: function( fn, fn2 ) { + toggle: function( fn, fn2, callback ) { var bool = typeof fn === "boolean"; if ( jQuery.isFunction(fn) && jQuery.isFunction(fn2) ) { @@ -96,15 +96,15 @@ jQuery.fn.extend({ }); } else { - this.animate(genFx("toggle", 3), fn, fn2); + this.animate(genFx("toggle", 3), fn, fn2, callback); } return this; }, - fadeTo: function( speed, to, callback ) { + fadeTo: function( speed, to, easing, callback ) { return this.filter(":hidden").css("opacity", 0).show().end() - .animate({opacity: to}, speed, callback); + .animate({opacity: to}, speed, easing, callback); }, animate: function( prop, speed, easing, callback ) { @@ -241,14 +241,14 @@ jQuery.each({ fadeIn: { opacity: "show" }, fadeOut: { opacity: "hide" } }, function( name, props ) { - jQuery.fn[ name ] = function( speed, callback ) { - return this.animate( props, speed, callback ); + jQuery.fn[ name ] = function( speed, easing, callback ) { + return this.animate( props, speed, easing, callback ); }; }); jQuery.extend({ speed: function( speed, easing, fn ) { - var opt = speed && typeof speed === "object" ? speed : { + var opt = speed && typeof speed === "object" ? jQuery.extend({}, speed) : { complete: fn || !fn && easing || jQuery.isFunction( speed ) && speed, duration: speed, @@ -256,7 +256,7 @@ jQuery.extend({ }; opt.duration = jQuery.fx.off ? 0 : typeof opt.duration === "number" ? opt.duration : - jQuery.fx.speeds[opt.duration] || jQuery.fx.speeds._default; + opt.duration in jQuery.fx.speeds ? jQuery.fx.speeds[opt.duration] : jQuery.fx.speeds._default; // Queueing opt.old = opt.complete; @@ -316,7 +316,7 @@ jQuery.fx.prototype = { return this.elem[ this.prop ]; } - var r = parseFloat( jQuery.css( this.elem, this.prop ), 10 ); + var r = parseFloat( jQuery.css( this.elem, this.prop ) ); return r && r > -10000 ? r : 0; }, @@ -329,7 +329,7 @@ jQuery.fx.prototype = { this.now = this.start; this.pos = this.state = 0; - var self = this; + var self = this, fx = jQuery.fx; function t( gotoEnd ) { return self.step(gotoEnd); } @@ -337,7 +337,7 @@ jQuery.fx.prototype = { t.elem = this.elem; if ( t() && jQuery.timers.push(t) && !timerId ) { - timerId = setInterval(jQuery.fx.tick, 13); + timerId = setInterval(fx.tick, fx.interval); } }, @@ -447,6 +447,8 @@ jQuery.extend( jQuery.fx, { jQuery.fx.stop(); } }, + + interval: 13, stop: function() { clearInterval( timerId );