X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=src%2Ffx%2Ffx.js;h=59cdceac59357687ffaef3893ffc072a64bcddd2;hb=e2b52e1e401af05a6fe3ca7bf9e714f973fc4d61;hp=163f0f65cb689fc8fda951469e59757b720d01ea;hpb=83b43a1e927d6b260f35f75bc2c3d177f271be93;p=jquery.git diff --git a/src/fx/fx.js b/src/fx/fx.js index 163f0f6..59cdcea 100644 --- a/src/fx/fx.js +++ b/src/fx/fx.js @@ -143,7 +143,7 @@ jQuery.fn.extend({ * @see slideToggle(String|Number,Function) */ slideDown: function(speed,callback){ - return this.animate({height: "show"}, speed, callback); + return this.filter(":hidden").animate({height: "show"}, speed, callback).end(); }, /** @@ -168,7 +168,7 @@ jQuery.fn.extend({ * @see slideToggle(String|Number,Function) */ slideUp: function(speed,callback){ - return this.animate({height: "hide"}, speed, callback); + return this.filter(":visible").animate({height: "hide"}, speed, callback).end(); }, /** @@ -222,7 +222,7 @@ jQuery.fn.extend({ * @see fadeTo(String|Number,Number,Function) */ fadeIn: function(speed, callback){ - return this.animate({opacity: "show"}, speed, callback); + return this.filter(":hidden").animate({opacity: "show"}, speed, callback).end(); }, /** @@ -248,7 +248,7 @@ jQuery.fn.extend({ * @see fadeTo(String|Number,Number,Function) */ fadeOut: function(speed, callback){ - return this.animate({opacity: "hide"}, speed, callback); + return this.filter(":visible").animate({opacity: "hide"}, speed, callback).end(); }, /** @@ -400,6 +400,8 @@ jQuery.extend({ } }, + timers: [], + /* * I originally wrote fx() as a clone of moo.fx and in the process * of making it small in size the code became illegible to sane @@ -452,9 +454,20 @@ jQuery.extend({ z.now = from; z.a(); - z.timer = setInterval(function(){ - z.step(from, to); - }, 13); + jQuery.timers.push(function(){ + return z.step(from, to); + }); + + if ( jQuery.timers.length == 1 ) { + var timer = setInterval(function(){ + jQuery.timers = jQuery.grep( jQuery.timers, function(fn){ + return fn(); + }); + + if ( !jQuery.timers.length ) + clearInterval( timer ); + }, 13); + } }; // Simple 'show' function @@ -516,10 +529,6 @@ jQuery.extend({ var t = (new Date()).getTime(); if (t > options.duration + z.startTime) { - // Stop the timer - clearInterval(z.timer); - z.timer = null; - z.now = lastNum; z.a(); @@ -555,6 +564,8 @@ jQuery.extend({ if ( done && jQuery.isFunction( options.complete ) ) // Execute the complete function options.complete.apply( elem ); + + return false; } else { var n = t - this.startTime; // Figure out where in the animation we are and set the number @@ -569,6 +580,8 @@ jQuery.extend({ // Perform the next step of the animation z.a(); } + + return true; }; }