X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=src%2Ffx%2Ffx.js;h=ca861b6bdc2e766e3dedba1328216c80649501a6;hb=f2f399dcd552e73f68c9e8adfe26ef7995724cb3;hp=51e81571819e7cd36c5dfcb475fd104001866de6;hpb=5e6c14993a1010a2f6e8ce1f1d5d64171d324581;p=jquery.git diff --git a/src/fx/fx.js b/src/fx/fx.js index 51e8157..ca861b6 100644 --- a/src/fx/fx.js +++ b/src/fx/fx.js @@ -110,9 +110,13 @@ jQuery.fn.extend({ toggle: function( fn, fn2 ){ return jQuery.isFunction(fn) && jQuery.isFunction(fn2) ? this._toggle( fn, fn2 ) : - this.animate({ - height: "toggle", width: "toggle", opacity: "toggle" - }, fn, fn2); + fn ? + this.animate({ + height: "toggle", width: "toggle", opacity: "toggle" + }, fn, fn2) : + this.each(function(){ + jQuery(this)[ jQuery(this).is(":hidden") ? "show" : "hide" ](); + }); }, /** @@ -311,19 +315,34 @@ jQuery.fn.extend({ opt = jQuery.speed(speed, easing, callback), self = this; - for ( var p in prop ) + for ( var p in prop ) { if ( prop[p] == "hide" && hidden || prop[p] == "show" && !hidden ) return jQuery.isFunction(opt.complete) && opt.complete.apply(this); - + + if ( p == "height" || p == "width" ) { + // Store display property + opt.display = jQuery.css(this, "display"); + + // Make sure that nothing sneaks out + opt.overflow = this.style.overflow; + } + } + + if ( opt.overflow != null ) + this.style.overflow = "hidden"; + this.curAnim = jQuery.extend({}, prop); jQuery.each( prop, function(name, val){ var e = new jQuery.fx( self, opt, name ); if ( val.constructor == Number ) - e.custom( e.cur(), val ); + e.custom( e.cur() || 0, val ); else e[ val == "toggle" ? hidden ? "show" : "hide" : val ]( prop ); }); + + // For JS strict compliance + return true; }); }, @@ -360,7 +379,7 @@ jQuery.extend({ complete: fn || !fn && easing || jQuery.isFunction( speed ) && speed, duration: speed, - easing: fn && easing || easing && easing.constructor != Function && easing || "swing" + easing: fn && easing || easing && easing.constructor != Function && easing }; opt.duration = (opt.duration && opt.duration.constructor == Number ? @@ -418,15 +437,6 @@ jQuery.extend({ // The styles var y = elem.style; - if ( prop == "height" || prop == "width" ) { - // Store display property - var oldDisplay = jQuery.css(elem, "display"); - - // Make sure that nothing sneaks out - var oldOverflow = y.overflow; - y.overflow = "hidden"; - } - // Simple function for setting a style value z.a = function(){ if ( options.step ) @@ -436,7 +446,10 @@ jQuery.extend({ jQuery.attr(y, "opacity", z.now); // Let attr handle opacity else { y[prop] = parseInt(z.now) + "px"; - y.display = "block"; // Set display property to block for animation + + // Set display property to block for height/width animations + if ( prop == "height" || prop == "width" ) + y.display = "block"; } }; @@ -525,12 +538,12 @@ jQuery.extend({ done = false; if ( done ) { - if ( oldDisplay != null ) { + if ( options.display != null ) { // Reset the overflow - y.overflow = oldOverflow; + y.overflow = options.overflow; // Reset the display - y.display = oldDisplay; + y.display = options.display; if ( jQuery.css(elem, "display") == "none" ) y.display = "block"; } @@ -557,7 +570,7 @@ jQuery.extend({ var p = n / options.duration; // Perform the easing function, defaults to swing - z.now = jQuery.easing[options.easing](p, n, firstNum, (lastNum-firstNum), options.duration); + z.now = jQuery.easing[options.easing || (jQuery.easing.swing ? "swing" : "linear")](p, n, firstNum, (lastNum-firstNum), options.duration); // Perform the next step of the animation z.a();