X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=src%2Ffx.js;h=0b5f8d8e1f496fed83b438537b5881a22782d4c7;hb=d7d908b05a442745c1a90728805b74db0a7921cf;hp=40bbc61edace1fb541bff244c9b8f0af19c8c200;hpb=e216243a03d13d659f9811ef20ede3b213fd33f1;p=jquery.git diff --git a/src/fx.js b/src/fx.js index 40bbc61..0b5f8d8 100644 --- a/src/fx.js +++ b/src/fx.js @@ -1,4 +1,5 @@ var elemdisplay = {}, + timerId, fxAttrs = [ // height animations [ "height", "marginTop", "marginBottom", "paddingTop", "paddingBottom" ], @@ -43,9 +44,15 @@ jQuery.fn.extend({ elemdisplay[ tagName ] = display; } - this[i].style.display = jQuery.data(this[i], "olddisplay", display); + jQuery.data(this[i], "olddisplay", display); } } + + // Set the display of the elements in a second loop + // to avoid the constant reflow + for ( var i = 0, l = this.length; i < l; i++ ){ + this[i].style.display = jQuery.data(this[i], "olddisplay") || ""; + } return this; } @@ -59,8 +66,14 @@ jQuery.fn.extend({ var old = jQuery.data(this[i], "olddisplay"); if ( !old && old !== "none" ) jQuery.data(this[i], "olddisplay", jQuery.css(this[i], "display")); + } + + // Set the display of the elements in a second loop + // to avoid the constant reflow + for ( var i = 0, l = this.length; i < l; i++ ){ this[i].style.display = "none"; } + return this; } }, @@ -82,7 +95,8 @@ jQuery.fn.extend({ }, fadeTo: function(speed,to,callback){ - return this.animate({opacity: to}, speed, callback); + return this.filter(":hidden").css('opacity', 0).show().end() + .animate({opacity: to}, speed, callback); }, animate: function( prop, speed, easing, callback ) { @@ -221,7 +235,6 @@ jQuery.extend({ }, timers: [], - timerId: null, fx: function( elem, options, prop ){ this.options = options; @@ -273,10 +286,8 @@ jQuery.fx.prototype = { t.elem = this.elem; - jQuery.timers.push(t); - - if ( t() && jQuery.timerId == null ) { - jQuery.timerId = setInterval(function(){ + if ( t() && jQuery.timers.push(t) && !timerId ) { + timerId = setInterval(function(){ var timers = jQuery.timers; for ( var i = 0; i < timers.length; i++ ) @@ -284,8 +295,8 @@ jQuery.fx.prototype = { timers.splice(i--, 1); if ( !timers.length ) { - clearInterval( jQuery.timerId ); - jQuery.timerId = null; + clearInterval( timerId ); + timerId = undefined; } }, 13); } @@ -294,7 +305,7 @@ jQuery.fx.prototype = { // Simple 'show' function show: function(){ // Remember where we started, so that we can go back to it later - this.options.orig[this.prop] = jQuery.attr( this.elem.style, this.prop ); + this.options.orig[this.prop] = jQuery.style( this.elem, this.prop ); this.options.show = true; // Begin the animation @@ -309,7 +320,7 @@ jQuery.fx.prototype = { // Simple 'hide' function hide: function(){ // Remember where we started, so that we can go back to it later - this.options.orig[this.prop] = jQuery.attr( this.elem.style, this.prop ); + this.options.orig[this.prop] = jQuery.style( this.elem, this.prop ); this.options.hide = true; // Begin the animation @@ -350,12 +361,11 @@ jQuery.fx.prototype = { // Reset the properties, if the item has been hidden or shown if ( this.options.hide || this.options.show ) for ( var p in this.options.curAnim ) - jQuery.attr(this.elem.style, p, this.options.orig[p]); - } - - if ( done ) + jQuery.style(this.elem, p, this.options.orig[p]); + // Execute the complete function this.options.complete.call( this.elem ); + } return false; } else { @@ -385,7 +395,7 @@ jQuery.extend( jQuery.fx, { step: { opacity: function(fx){ - jQuery.attr(fx.elem.style, "opacity", fx.now); + jQuery.style(fx.elem, "opacity", fx.now); }, _default: function(fx){