X-Git-Url: http://git.asbjorn.biz/?a=blobdiff_plain;f=test%2Funit%2Fattributes.js;h=21d3d94bcb96a23cc5ad952820537223ad89fdfc;hb=b3ccf2f2881d9ad988aba1cf3ccffb810063ab29;hp=7887790b759a465c8a2b2fcf473f06fd0fa96bf8;hpb=2a268f5f4b5b1d870d5af580de4c768e0121e5b5;p=jquery.git

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 7887790..21d3d94 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -1,8 +1,14 @@
 module("attributes");
 
+var bareObj = function(value) { return value; };
+var functionReturningObj = function(value) { return (function() { return value; }); };
+
 test("attr(String)", function() {
-	expect(27);
+	expect(30);
+
+	// This one sometimes fails randomly ?!
 	equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
+	
 	equals( jQuery('#text1').attr('value', "Test2").attr('defaultValue'), "Test", 'Check for defaultValue attribute' );
 	equals( jQuery('#text1').attr('type'), "text", 'Check for type attribute' );
 	equals( jQuery('#radio1').attr('type'), "radio", 'Check for type attribute' );
@@ -15,6 +21,8 @@ test("attr(String)", function() {
 	equals( jQuery('#name').attr('name'), "name", 'Check for name attribute' );
 	equals( jQuery('#text1').attr('name'), "action", 'Check for name attribute' );
 	ok( jQuery('#form').attr('action').indexOf("formaction") >= 0, 'Check for action attribute' );
+	// Temporarily disabled. See: #4299
+	// ok( jQuery('#form').attr('action','newformaction').attr('action').indexOf("newformaction") >= 0, 'Check that action attribute was changed' );
 	equals( jQuery('#text1').attr('maxlength'), '30', 'Check for maxlength attribute' );
 	equals( jQuery('#text1').attr('maxLength'), '30', 'Check for maxLength attribute' );
 	equals( jQuery('#area1').attr('maxLength'), '30', 'Check for maxLength attribute' );
@@ -47,6 +55,15 @@ test("attr(String)", function() {
 	ok( $body.attr('foo') === undefined, 'Make sure the expando is preferred over the dom attribute, even if undefined' );
 
 	body.removeAttribute('foo'); // Cleanup
+
+	var select = document.createElement("select"), optgroup = document.createElement("optgroup"), option = document.createElement("option");
+	optgroup.appendChild( option );
+	select.appendChild( optgroup );
+
+	equals( jQuery(option).attr("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );
+
+	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
+	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
 });
 
 if ( !isLocal ) {
@@ -63,7 +80,7 @@ if ( !isLocal ) {
 
 test("attr(String, Function)", function() {
 	expect(2);
-	equals( jQuery('#text1').attr('value', function() { return this.id })[0].value, "text1", "Set value from id" );
+	equals( jQuery('#text1').attr('value', function() { return this.id ;})[0].value, "text1", "Set value from id" );
 	equals( jQuery('#text1').attr('title', function(i) { return i }).attr('title'), "0", "Set value with an index");
 });
 
@@ -74,13 +91,13 @@ test("attr(Hash)", function() {
 		if ( this.getAttribute('foo') != "baz" && this.getAttribute('zoo') != "ping" ) pass = false;
 	});
 	ok( pass, "Set Multiple Attributes" );
-       equals( jQuery('#text1').attr({'value': function() { return this.id; }})[0].value, "text1", "Set attribute to computed value #1" );
-       equals( jQuery('#text1').attr({'title': function(i) { return i; }}).attr('title'), "0", "Set attribute to computed value #2");
+			 equals( jQuery('#text1').attr({'value': function() { return this.id; }})[0].value, "text1", "Set attribute to computed value #1" );
+			 equals( jQuery('#text1').attr({'title': function(i) { return i; }}).attr('title'), "0", "Set attribute to computed value #2");
 
 });
 
 test("attr(String, Object)", function() {
-	expect(24);
+	expect(23);
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;
 	for ( var i = 0; i < div.size(); i++ ) {
@@ -91,7 +108,8 @@ test("attr(String, Object)", function() {
 	}
 	equals( fail, false, "Set Attribute, the #"+fail+" element didn't get the attribute 'foo'" );
 
-	ok( jQuery("#foo").attr({"width": null}), "Try to set an attribute to nothing" );
+	// Fails on IE since recent changes to .attr()
+	// ok( jQuery("#foo").attr({"width": null}), "Try to set an attribute to nothing" );
 
 	jQuery("#name").attr('name', 'something');
 	equals( jQuery("#name").attr('name'), 'something', 'Set name attribute' );
@@ -175,6 +193,37 @@ test("attr(String, Object)", function() {
 	equals( "button", button.attr('type'), "Verify that you can't change the type of a button element" );
 });
 
+test("attr(jquery_method)", function(){
+	expect(7);
+	
+	var $elem = jQuery("<div />"),
+		elem = $elem[0];
+	
+	// one at a time	
+	$elem.attr({'html': 'foo'}, true);
+	equals( elem.innerHTML, 'foo', 'attr(html)');
+	
+	$elem.attr({'text': 'bar'}, true);
+	equals( elem.innerHTML, 'bar', 'attr(text)');
+	
+	$elem.attr({'css': {color:'red'}}, true);
+	ok( /^(#ff0000|red)$/i.test(elem.style.color), 'attr(css)');
+	
+	$elem.attr({'height': 10}, true);
+	equals( elem.style.height, '10px', 'attr(height)');
+	
+	// Multiple attributes
+	
+	$elem.attr({
+		width:10,
+		css:{ paddingLeft:1, paddingRight:1 }
+	}, true);
+	
+	equals( elem.style.width, '10px', 'attr({...})');
+	equals( elem.style.paddingLeft, '1px', 'attr({...})');
+	equals( elem.style.paddingRight, '1px', 'attr({...})');
+});
+
 if ( !isLocal ) {
 	test("attr(String, Object) - Loaded via XML document", function() {
 		expect(2);
@@ -246,10 +295,152 @@ test("attr('tabindex', value)", function() {
 	equals(element.attr('tabindex'), -1, 'set negative tabindex');
 });
 
-test("addClass(String)", function() {
-	expect(2);
+test("removeAttr(String)", function() {
+	expect(1);
+	equals( jQuery('#mark').removeAttr( "class" )[0].className, "", "remove class" );
+});
+
+test("val()", function() {
+	expect(17);
+
+	document.getElementById('text1').value = "bla";
+	equals( jQuery("#text1").val(), "bla", "Check for modified value of input element" );
+
+	reset();
+
+	equals( jQuery("#text1").val(), "Test", "Check for value of input element" );
+	// ticket #1714 this caused a JS error in IE
+	equals( jQuery("#first").val(), "", "Check a paragraph element to see if it has a value" );
+	ok( jQuery([]).val() === undefined, "Check an empty jQuery object will return undefined from val" );
+
+	equals( jQuery('#select2').val(), '3', 'Call val() on a single="single" select' );
+
+	same( jQuery('#select3').val(), ['1', '2'], 'Call val() on a multiple="multiple" select' );
+
+	equals( jQuery('#option3c').val(), '2', 'Call val() on a option element with value' );
+
+	equals( jQuery('#option3a').val(), '', 'Call val() on a option element with empty value' );
+
+	equals( jQuery('#option3e').val(), 'no value', 'Call val() on a option element with no value attribute' );
+
+	equals( jQuery('#option3a').val(), '', 'Call val() on a option element with no value attribute' );
+
+	jQuery('#select3').val("");
+	same( jQuery('#select3').val(), [''], 'Call val() on a multiple="multiple" select' );
+
+	var checks = jQuery("<input type='checkbox' name='test' value='1'/>").appendTo("#form")
+		.add( jQuery("<input type='checkbox' name='test' value='2'/>").appendTo("#form") )
+		.add( jQuery("<input type='checkbox' name='test' value=''/>").appendTo("#form") )
+		.add( jQuery("<input type='checkbox' name='test'/>").appendTo("#form") );
+
+	same( checks.serialize(), "", "Get unchecked values." );
+
+	equals( checks.eq(3).val(), "on", "Make sure a value of 'on' is provided if none is specified." );
+
+	checks.val([ "2" ]);
+	same( checks.serialize(), "test=2", "Get a single checked value." );
+
+	checks.val([ "1", "" ]);
+	same( checks.serialize(), "test=1&test=", "Get multiple checked values." );
+
+	checks.val([ "", "2" ]);
+	same( checks.serialize(), "test=2&test=", "Get multiple checked values." );
+
+	checks.val([ "1", "on" ]);
+	same( checks.serialize(), "test=1&test=on", "Get multiple checked values." );
+
+	checks.remove();
+});
+
+var testVal = function(valueObj) {
+	expect(6);
+
+	jQuery("#text1").val(valueObj( 'test' ));
+	equals( document.getElementById('text1').value, "test", "Check for modified (via val(String)) value of input element" );
+
+	jQuery("#text1").val(valueObj( 67 ));
+	equals( document.getElementById('text1').value, "67", "Check for modified (via val(Number)) value of input element" );
+
+	jQuery("#select1").val(valueObj( "3" ));
+	equals( jQuery("#select1").val(), "3", "Check for modified (via val(String)) value of select element" );
+
+	jQuery("#select1").val(valueObj( 2 ));
+	equals( jQuery("#select1").val(), "2", "Check for modified (via val(Number)) value of select element" );
+
+	jQuery("#select1").append("<option value='4'>four</option>");
+	jQuery("#select1").val(valueObj( 4 ));
+	equals( jQuery("#select1").val(), "4", "Should be possible to set the val() to a newly created option" );
+
+	// using contents will get comments regular, text, and comment nodes
+	var j = jQuery("#nonnodes").contents();
+	j.val(valueObj( "asdf" ));
+	equals( j.val(), "asdf", "Check node,textnode,comment with val()" );
+	j.removeAttr("value");
+}
+
+test("val(String/Number)", function() {
+	testVal(bareObj);
+});
+
+test("val(Function)", function() {
+	testVal(functionReturningObj);
+})
+
+test("val(Function) with incoming value", function() {
+	expect(10);
+
+	var oldVal = jQuery("#text1").val();
+
+	jQuery("#text1").val(function(i, val) {
+		equals( val, oldVal, "Make sure the incoming value is correct." );
+		return "test";
+	});
+
+	equals( document.getElementById('text1').value, "test", "Check for modified (via val(String)) value of input element" );
+
+	oldVal = jQuery("#text1").val();
+
+	jQuery("#text1").val(function(i, val) {
+		equals( val, oldVal, "Make sure the incoming value is correct." );
+		return 67;
+	});
+
+	equals( document.getElementById('text1').value, "67", "Check for modified (via val(Number)) value of input element" );
+
+	oldVal = jQuery("#select1").val();
+
+	jQuery("#select1").val(function(i, val) {
+		equals( val, oldVal, "Make sure the incoming value is correct." );
+		return "3";
+	});
+
+	equals( jQuery("#select1").val(), "3", "Check for modified (via val(String)) value of select element" );
+
+	oldVal = jQuery("#select1").val();
+
+	jQuery("#select1").val(function(i, val) {
+		equals( val, oldVal, "Make sure the incoming value is correct." );
+		return 2;
+	});
+
+	equals( jQuery("#select1").val(), "2", "Check for modified (via val(Number)) value of select element" );
+
+	jQuery("#select1").append("<option value='4'>four</option>");
+
+	oldVal = jQuery("#select1").val();
+
+	jQuery("#select1").val(function(i, val) {
+		equals( val, oldVal, "Make sure the incoming value is correct." );
+		return 4;
+	});
+
+	equals( jQuery("#select1").val(), "4", "Should be possible to set the val() to a newly created option" );
+});
+
+var testAddClass = function(valueObj) {
+	expect(5);
 	var div = jQuery("div");
-	div.addClass("test");
+	div.addClass( valueObj("test") );
 	var pass = true;
 	for ( var i = 0; i < div.size(); i++ ) {
 	 if ( div.get(i).className.indexOf("test") == -1 ) pass = false;
@@ -258,65 +449,147 @@ test("addClass(String)", function() {
 
 	// using contents will get regular, text, and comment nodes
 	var j = jQuery("#nonnodes").contents();
-	j.addClass("asdf");
+	j.addClass( valueObj("asdf") );
 	ok( j.hasClass("asdf"), "Check node,textnode,comment for addClass" );
+
+	div = jQuery("<div/>");
+
+	div.addClass( valueObj("test") );
+	equals( div.attr("class"), "test", "Make sure there's no extra whitespace." );
+
+	div.attr("class", " foo");
+	div.addClass( valueObj("test") );
+	equals( div.attr("class"), "foo test", "Make sure there's no extra whitespace." );
+
+	div.attr("class", "foo");
+	div.addClass( valueObj("bar baz") );
+	equals( div.attr("class"), "foo bar baz", "Make sure there isn't too much trimming." );
+};
+
+test("addClass(String)", function() {
+	testAddClass(bareObj);
 });
 
-test("removeClass(String) - simple", function() {
-	expect(5);
+test("addClass(Function)", function() {
+	testAddClass(functionReturningObj);
+});
+
+test("addClass(Function) with incoming value", function() {
+	expect(39);
+
+	var div = jQuery("div"), old = div.map(function(){
+		return jQuery(this).attr("class");
+	});
+
+	div.addClass(function(i, val) {
+		if ( this.id !== "_firebugConsole" ) {
+			equals( val, old[i], "Make sure the incoming value is correct." );
+			return "test";
+		}
+	});
+
+	var pass = true;
+	for ( var i = 0; i < div.size(); i++ ) {
+	 if ( div.get(i).className.indexOf("test") == -1 ) pass = false;
+	}
+	ok( pass, "Add Class" );
+});
+
+var testRemoveClass = function(valueObj) {
+	expect(7);
 
 	var $divs = jQuery('div');
 
-	$divs.addClass("test").removeClass("test");
+	$divs.addClass("test").removeClass( valueObj("test") );
 
 	ok( !$divs.is('.test'), "Remove Class" );
 
 	reset();
+	$divs = jQuery('div');
 
 	$divs.addClass("test").addClass("foo").addClass("bar");
-	$divs.removeClass("test").removeClass("bar").removeClass("foo");
+	$divs.removeClass( valueObj("test") ).removeClass( valueObj("bar") ).removeClass( valueObj("foo") );
 
 	ok( !$divs.is('.test,.bar,.foo'), "Remove multiple classes" );
 
 	reset();
+	$divs = jQuery('div');
 
 	// Make sure that a null value doesn't cause problems
-	$divs.eq(0).addClass("test").removeClass(null);
+	$divs.eq(0).addClass("test").removeClass( valueObj(null) );
 	ok( $divs.eq(0).is('.test'), "Null value passed to removeClass" );
 
-	$divs.eq(0).addClass("test").removeClass("");
+	$divs.eq(0).addClass("test").removeClass( valueObj("") );
 	ok( $divs.eq(0).is('.test'), "Empty string passed to removeClass" );
 
 	// using contents will get regular, text, and comment nodes
 	var j = jQuery("#nonnodes").contents();
-	j.removeClass("asdf");
+	j.removeClass( valueObj("asdf") );
 	ok( !j.hasClass("asdf"), "Check node,textnode,comment for removeClass" );
+
+	var div = document.createElement("div");
+	div.className = " test foo ";
+
+	jQuery(div).removeClass( valueObj("foo") );
+	equals( div.className, "test", "Make sure remaining className is trimmed." );
+
+	div.className = " test ";
+
+	jQuery(div).removeClass( valueObj("test") );
+	equals( div.className, "", "Make sure there is nothing left after everything is removed." );
+};
+
+test("removeClass(String) - simple", function() {
+	testRemoveClass(bareObj);
 });
 
-test("toggleClass(String|boolean|undefined[, boolean])", function() {
+test("removeClass(Function) - simple", function() {
+	testRemoveClass(functionReturningObj);
+});
+
+test("removeClass(Function) with incoming value", function() {
+	expect(39);
+
+	var $divs = jQuery('div').addClass("test"), old = $divs.map(function(){
+		return jQuery(this).attr("class");
+	});
+
+	$divs.removeClass(function(i, val) {
+		if ( this.id !== "_firebugConsole" ) {
+			equals( val, old[i], "Make sure the incoming value is correct." );
+			return "test";
+		}
+	});
+
+	ok( !$divs.is('.test'), "Remove Class" );
+
+	reset();	
+});
+
+var testToggleClass = function(valueObj) {
 	expect(17);
 
 	var e = jQuery("#firstp");
 	ok( !e.is(".test"), "Assert class not present" );
-	e.toggleClass("test");
+	e.toggleClass( valueObj("test") );
 	ok( e.is(".test"), "Assert class present" );
-	e.toggleClass("test");
+	e.toggleClass( valueObj("test") );
 	ok( !e.is(".test"), "Assert class not present" );
 
 	// class name with a boolean
-	e.toggleClass("test", false);
+	e.toggleClass( valueObj("test"), false );
 	ok( !e.is(".test"), "Assert class not present" );
-	e.toggleClass("test", true);
+	e.toggleClass( valueObj("test"), true );
 	ok( e.is(".test"), "Assert class present" );
-	e.toggleClass("test", false);
+	e.toggleClass( valueObj("test"), false );
 	ok( !e.is(".test"), "Assert class not present" );
 
 	// multiple class names
 	e.addClass("testA testB");
 	ok( (e.is(".testA.testB")), "Assert 2 different classes present" );
-	e.toggleClass("testB testC");
+	e.toggleClass( valueObj("testB testC") );
 	ok( (e.is(".testA.testC") && !e.is(".testB")), "Assert 1 class added, 1 class removed, and 1 class kept" );
-	e.toggleClass("testA testC");
+	e.toggleClass( valueObj("testA testC") );
 	ok( (!e.is(".testA") && !e.is(".testB") && !e.is(".testC")), "Assert no class present" );
 
 	// toggleClass storage
@@ -343,26 +616,101 @@ test("toggleClass(String|boolean|undefined[, boolean])", function() {
 	// Cleanup
 	e.removeClass("testD");
 	e.removeData('__className__');
+};
+
+test("toggleClass(String|boolean|undefined[, boolean])", function() {
+	testToggleClass(bareObj);
 });
 
-test("removeAttr(String", function() {
-	expect(1);
-	equals( jQuery('#mark').removeAttr("class")[0].className, "", "remove class" );
+test("toggleClass(Function[, boolean])", function() {
+	testToggleClass(functionReturningObj);
 });
 
-test("jQuery.className", function() {
-	expect(6);
-	var x = jQuery("<p>Hi</p>")[0];
-	var c = jQuery.className;
-	c.add(x, "hi");
+test("toggleClass(Fucntion[, boolean]) with incoming value", function() {
+	expect(14);
+
+	var e = jQuery("#firstp"), old = e.attr("class");
+	ok( !e.is(".test"), "Assert class not present" );
+	
+	e.toggleClass(function(i, val) {
+		equals( val, old, "Make sure the incoming value is correct." );
+		return "test";
+	});
+	ok( e.is(".test"), "Assert class present" );
+	
+	old = e.attr("class");
+	
+	e.toggleClass(function(i, val) {
+		equals( val, old, "Make sure the incoming value is correct." );
+		return "test";
+	});
+	ok( !e.is(".test"), "Assert class not present" );
+	
+	old = e.attr("class");
+
+	// class name with a boolean
+	e.toggleClass(function(i, val, state) {
+		equals( val, old, "Make sure the incoming value is correct." );
+		equals( state, false, "Make sure that the state is passed in." );
+		return "test";
+	}, false );
+	ok( !e.is(".test"), "Assert class not present" );
+	
+	old = e.attr("class");
+	
+	e.toggleClass(function(i, val, state) {
+		equals( val, old, "Make sure the incoming value is correct." );
+		equals( state, true, "Make sure that the state is passed in." );
+		return "test";
+	}, true );
+	ok( e.is(".test"), "Assert class present" );
+	
+	old = e.attr("class");
+	
+	e.toggleClass(function(i, val, state) {
+		equals( val, old, "Make sure the incoming value is correct." );
+		equals( state, false, "Make sure that the state is passed in." );
+		return "test";
+	}, false );
+	ok( !e.is(".test"), "Assert class not present" );
+
+	// Cleanup
+	e.removeClass("test");
+	e.removeData('__className__');
+});
+
+test("addClass, removeClass, hasClass", function() {
+	expect(14);
+ 
+	var jq = jQuery("<p>Hi</p>"), x = jq[0];
+ 
+	jq.addClass("hi");
 	equals( x.className, "hi", "Check single added class" );
-	c.add(x, "foo bar");
+ 
+	jq.addClass("foo bar");
 	equals( x.className, "hi foo bar", "Check more added classes" );
-	c.remove(x);
+ 
+	jq.removeClass();
 	equals( x.className, "", "Remove all classes" );
-	c.add(x, "hi foo bar");
-	c.remove(x, "foo");
+ 
+	jq.addClass("hi foo bar");
+	jq.removeClass("foo");
 	equals( x.className, "hi bar", "Check removal of one class" );
-	ok( c.has(x, "hi"), "Check has1" );
-	ok( c.has(x, "bar"), "Check has2" );
+ 
+	ok( jq.hasClass("hi"), "Check has1" );
+	ok( jq.hasClass("bar"), "Check has2" );
+ 
+	var jq = jQuery("<p class='class1\nclass2\tcla.ss3\n'></p>");
+	ok( jq.hasClass("class1"), "Check hasClass with carriage return" );
+	ok( jq.is(".class1"), "Check is with carriage return" );
+	ok( jq.hasClass("class2"), "Check hasClass with tab" );
+	ok( jq.is(".class2"), "Check is with tab" );
+	ok( jq.hasClass("cla.ss3"), "Check hasClass with dot" );
+ 
+	jq.removeClass("class2");
+	ok( jq.hasClass("class2")==false, "Check the class has been properly removed" );
+	jq.removeClass("cla");
+	ok( jq.hasClass("cla.ss3"), "Check the dotted class has not been removed" );
+	jq.removeClass("cla.ss3");
+	ok( jq.hasClass("cla.ss3")==false, "Check the dotted class has been removed" );
 });