git.asbjorn.biz
/
jquery.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
7f5179b
)
Make sure that undefined is always returned for undefined data properties. Fixes...
author
jeresig
<jeresig@gmail.com>
Fri, 26 Feb 2010 17:35:04 +0000
(12:35 -0500)
committer
jeresig
<jeresig@gmail.com>
Fri, 26 Feb 2010 17:35:04 +0000
(12:35 -0500)
src/data.js
patch
|
blob
|
history
test/unit/data.js
patch
|
blob
|
history
diff --git
a/src/data.js
b/src/data.js
index
b9986f5
..
a97ac04
100644
(file)
--- a/
src/data.js
+++ b/
src/data.js
@@
-25,7
+25,7
@@
jQuery.extend({
var id = elem[ expando ], cache = jQuery.cache, thisCache;
if ( !id && typeof name === "string" && data === undefined ) {
var id = elem[ expando ], cache = jQuery.cache, thisCache;
if ( !id && typeof name === "string" && data === undefined ) {
- return null;
+ return;
}
// Compute a unique ID for the element
}
// Compute a unique ID for the element
diff --git
a/test/unit/data.js
b/test/unit/data.js
index
79b23c6
..
0d75bc4
100644
(file)
--- a/
test/unit/data.js
+++ b/
test/unit/data.js
@@
-24,12
+24,15
@@
test("expando", function(){
});
test("jQuery.data", function() {
});
test("jQuery.data", function() {
- expect(8);
- var div = jQuery("#foo")[0];
- equals( jQuery.data(div, "test"), undefined, "Check for no data exists" );
+ expect(9);
+ var div = document.createElement("div");
+
+ ok( jQuery.data(div, "test") === undefined, "Check for no data exists" );
jQuery.data(div, "test", "success");
equals( jQuery.data(div, "test"), "success", "Check for added data" );
jQuery.data(div, "test", "success");
equals( jQuery.data(div, "test"), "success", "Check for added data" );
+
+ ok( jQuery.data(div, "notexist") === undefined, "Check for no data exists" );
var data = jQuery.data(div);
same( data, { "test": "success" }, "Return complete data set" );
var data = jQuery.data(div);
same( data, { "test": "success" }, "Return complete data set" );
@@
-57,18
+60,25
@@
test(".data()", function() {
})
test(".data(String) and .data(String, Object)", function() {
})
test(".data(String) and .data(String, Object)", function() {
- expect(22);
- var div = jQuery("#foo");
- equals( div.data("test"), undefined, "Check for no data exists" );
+ expect(23);
+ var div = jQuery("<div/>");
+
+ ok( div.data("test") === undefined, "Check for no data exists" );
+
div.data("test", "success");
equals( div.data("test"), "success", "Check for added data" );
div.data("test", "success");
equals( div.data("test"), "success", "Check for added data" );
+
div.data("test", "overwritten");
equals( div.data("test"), "overwritten", "Check for overwritten data" );
div.data("test", "overwritten");
equals( div.data("test"), "overwritten", "Check for overwritten data" );
+
div.data("test", undefined);
equals( div.data("test"), "overwritten", "Check that data wasn't removed");
div.data("test", undefined);
equals( div.data("test"), "overwritten", "Check that data wasn't removed");
+
div.data("test", null);
ok( div.data("test") === null, "Check for null data");
div.data("test", null);
ok( div.data("test") === null, "Check for null data");
+ ok( div.data("notexist") === undefined, "Check for no data exists" );
+
div.data("test", "overwritten");
var hits = {test:0}, gets = {test:0};
div.data("test", "overwritten");
var hits = {test:0}, gets = {test:0};