From: Ariel Flesler <aflesler@gmail.com>
Date: Wed, 28 May 2008 20:43:13 +0000 (+0000)
Subject: jquery event: caching the props array and fixing the loop that goes thru it. It was... 
X-Git-Url: http://git.asbjorn.biz/?a=commitdiff_plain;h=abb055bb498c4938b8663eb37c98e9f9e8fd8c9e;p=jquery.git

jquery event: caching the props array and fixing the loop that goes thru it. It was accessing an invalid index.
---

diff --git a/src/event.js b/src/event.js
index 2bdf9ab..bcfd045 100644
--- a/src/event.js
+++ b/src/event.js
@@ -274,6 +274,8 @@ jQuery.event = {
 		return val;
 	},
 
+	props: "altKey attrChange attrName bubbles button cancelable charCode clientX clientY ctrlKey currentTarget data detail eventPhase fromElement handler keyCode metaKey newValue originalTarget pageX pageY prevValue relatedNode relatedTarget screenX screenY shiftKey srcElement target timeStamp toElement type view wheelDelta which".split(" "),
+
 	fix: function(event) {
 		if ( event[expando] == true )
 			return event;
@@ -282,9 +284,11 @@ jQuery.event = {
 		// and "clone" to set read-only properties
 		var originalEvent = event;
 		event = { originalEvent: originalEvent };
-		var props = "altKey attrChange attrName bubbles button cancelable charCode clientX clientY ctrlKey currentTarget data detail eventPhase fromElement handler keyCode metaKey newValue originalTarget pageX pageY prevValue relatedNode relatedTarget screenX screenY shiftKey srcElement target timeStamp toElement type view wheelDelta which".split(" ");
-		for ( var i=props.length; i; i-- )
-			event[ props[i] ] = originalEvent[ props[i] ];
+
+		for ( var i = this.props.length, prop; i; ){
+			prop = this.props[ --i ];
+			event[ prop ] = originalEvent[ prop ];
+		}
 
 		// Mark it as fixed
 		event[expando] = true;