Fixed typo in logic, also disabled function setters in this case to allow the functi...

[jquery.git] / src / core.js

diff --git a/src/core.js b/src/core.js
index 3b6cfff..edd1089 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -33,7 +33,10 @@ var jQuery = function( selector, context ) {
        rsingleTag = /^<(\w+)\s*\/?>(?:<\/\1>)?$/,
 
        // Keep a UserAgent string for use with jQuery.browser
-       userAgent = navigator.userAgent.toLowerCase(),
+       userAgent = navigator.userAgent,
+
+       // For matching the engine and version of the browser
+       browserMatch,
        
        // Has the ready events already been bound?
        readyBound = false,
@@ -313,10 +316,10 @@ jQuery.extend = jQuery.fn.extend = function() {
                                        continue;
                                }
 
-                               // Recurse if we're merging object literal values
-                               if ( deep && copy && jQuery.isPlainObject(copy) ) {
-                                       // Don't extend not object literals
-                                       var clone = src && jQuery.isPlainObject(src) ? src : {};
+                               // Recurse if we're merging object literal values or arrays
+                               if ( deep && copy && ( jQuery.isPlainObject(copy) || jQuery.isArray(copy) ) ) {
+                                       var clone = src && ( jQuery.isPlainObject(src) || jQuery.isArray(src) ) ? src
+                                               : jQuery.isArray(copy) ? [] : {};
 
                                        // Never move original objects, clone them
                                        target[ name ] = jQuery.extend( deep, clone, copy );
@@ -464,6 +467,8 @@ jQuery.extend({
                return true;
        },
 
+       noop: function() {},
+
        // Evalulates a script in a global context
        globalEval: function( data ) {
                if ( data && rnotwhite.test(data) ) {
@@ -647,17 +652,42 @@ jQuery.extend({
 
        // Use of jQuery.browser is frowned upon.
        // More details: http://docs.jquery.com/Utilities/jQuery.browser
-       browser: {
-               version: (/.*?(?:firefox|safari|opera|msie)[\/ ]([\d.]+)/.exec(userAgent) || [0,"0"])[1],
-               safari: /safari/.test( userAgent ),
-               opera: /opera/.test( userAgent ),
-               msie: /msie/.test( userAgent ) && !/opera/.test( userAgent ),
-               firefox: /firefox/.test( userAgent )
-       }
+       uaMatch: function( ua ) {
+               var ret = { browser: "" };
+
+               ua = ua.toLowerCase();
+
+               if ( /webkit/.test( ua ) ) {
+                       ret = { browser: "webkit", version: /webkit[\/ ]([\w.]+)/ };
+
+               } else if ( /opera/.test( ua ) ) {
+                       ret = { browser: "opera", version:  /version/.test( ua ) ? /version[\/ ]([\w.]+)/ : /opera[\/ ]([\w.]+)/ };
+                       
+               } else if ( /msie/.test( ua ) ) {
+                       ret = { browser: "msie", version: /msie ([\w.]+)/ };
+
+               } else if ( /mozilla/.test( ua ) && !/compatible/.test( ua ) ) {
+                       ret = { browser: "mozilla", version: /rv:([\w.]+)/ };
+               }
+
+               ret.version = (ret.version && ret.version.exec( ua ) || [0, "0"])[1];
+
+               return ret;
+       },
+
+       browser: {}
 });
 
-// Deprecated
-jQuery.browser.mozilla = /mozilla/.test( userAgent ) && !/(compatible|webkit)/.test( userAgent );
+browserMatch = jQuery.uaMatch( userAgent );
+if ( browserMatch.browser ) {
+       jQuery.browser[ browserMatch.browser ] = true;
+       jQuery.browser.version = browserMatch.version;
+}
+
+// Deprecated, use jQuery.browser.webkit instead
+if ( jQuery.browser.webkit ) {
+       jQuery.browser.safari = true;
+}
 
 if ( indexOf ) {
        jQuery.inArray = function( elem, array ) {
@@ -742,10 +772,10 @@ function access( elems, key, value, exec, fn, pass ) {
        // Setting one attribute
        if ( value !== undefined ) {
                // Optionally, function values get executed if exec is true
-               exec = exec && jQuery.isFunction(value);
+               exec = !pass && exec && jQuery.isFunction(value);
                
                for ( var i = 0; i < length; i++ ) {
-                       fn( elems[i], key, exec ? value.call( elems[i], i ) : value, pass );
+                       fn( elems[i], key, exec ? value.call( elems[i], i, fn( elems[i], key ) ) : value, pass );
                }
                
                return elems;