*/
toggle: function( fn, fn2 ){
var args = arguments;
- return fn && fn.constructor == Function && fn2 && fn2.constructor == Function ?
+ return jQuery.isFunction(fn) && jQuery.isFunction(fn2) ?
this._toggle( fn, fn2 ) :
this.each(function(){
jQuery(this)[ jQuery(this).is(":hidden") ? "show" : "hide" ]
},
/**
- * A function for making your own, custom, animations. The key aspect of
+ * A function for making your own, custom animations. The key aspect of
* this function is the object of style properties that will be animated,
* and to what end. Each key within the object represents a style property
* that will also be animated (for example: "height", "top", or "opacity").
*
+ * Note that properties should be specified using camel case
+ * eg. marginLeft instead of margin-left.
+ *
* The value associated with the key represents to what end the property
* will be animated. If a number is provided as the value, then the style
* property will be transitioned from its current state to that new number.
- * Oterwise if the string "hide", "show", or "toggle" is provided, a default
+ * Otherwise if the string "hide", "show", or "toggle" is provided, a default
* animation will be constructed for that property.
*
* @example $("p").animate({
speed: function(speed, easing, fn) {
var opt = speed && speed.constructor == Object ? speed : {
complete: fn || !fn && easing ||
- speed && speed.constructor == Function && speed,
+ jQuery.isFunction( speed ) && speed,
duration: speed,
easing: fn && easing || easing && easing.constructor != Function && easing
};
{ slow: 600, fast: 200 }[opt.duration]) || 400;
// Queueing
- opt.oldComplete = opt.complete;
+ opt.old = opt.complete;
opt.complete = function(){
jQuery.dequeue(this, "fx");
- if ( opt.oldComplete && opt.oldComplete.constructor == Function )
- opt.oldComplete.apply( this );
+ if ( jQuery.isFunction( opt.old ) )
+ opt.old.apply( this );
};
return opt;
// The styles
var y = elem.style;
- // Store display property
- var oldDisplay = jQuery.css(elem, 'display');
- // Set display property to block for animation
- y.display = "block";
- // Make sure that nothing sneaks out
- y.overflow = "hidden";
+ if ( prop == "height" || prop == "width" ) {
+ // Store display property
+ var oldDisplay = jQuery.css(elem, "display");
+
+ // Make sure that nothing sneaks out
+ var oldOverflow = y.overflow;
+ y.overflow = "hidden";
+ }
// Simple function for setting a style value
z.a = function(){
if ( prop == "opacity" )
jQuery.attr(y, "opacity", z.now); // Let attr handle opacity
- else if ( parseInt(z.now) ) // My hate for IE will never die
+ else {
y[prop] = parseInt(z.now) + "px";
+ y.display = "block"; // Set display property to block for animation
+ }
};
// Figure out the maximum number to run to
if ( !elem.orig ) elem.orig = {};
// Remember where we started, so that we can go back to it later
- elem.orig[prop] = this.cur();
+ elem.orig[prop] = jQuery.attr( elem.style, prop );
options.show = true;
// Begin the animation
- z.custom(0, elem.orig[prop]);
+ z.custom(0, this.cur());
// Stupid IE, look what you made me do
if ( prop != "opacity" )
if ( !elem.orig ) elem.orig = {};
// Remember where we started, so that we can go back to it later
- elem.orig[prop] = this.cur();
+ elem.orig[prop] = jQuery.attr( elem.style, prop );
options.hide = true;
// Begin the animation
- z.custom(elem.orig[prop], 0);
+ z.custom(this.cur(), 0);
};
//Simple 'toggle' function
if ( !elem.orig ) elem.orig = {};
// Remember where we started, so that we can go back to it later
- elem.orig[prop] = this.cur();
+ elem.orig[prop] = jQuery.attr( elem.style, prop );
- if(oldDisplay == 'none') {
+ if(oldDisplay == "none") {
options.show = true;
// Stupid IE, look what you made me do
y[prop] = "1px";
// Begin the animation
- z.custom(0, elem.orig[prop]);
+ z.custom(0, this.cur());
} else {
options.hide = true;
// Begin the animation
- z.custom(elem.orig[prop], 0);
+ z.custom(this.cur(), 0);
}
};
done = false;
if ( done ) {
- // Reset the overflow
- y.overflow = '';
+ if ( oldDisplay ) {
+ // Reset the overflow
+ y.overflow = oldOverflow;
- // Reset the display
- y.display = oldDisplay;
- if (jQuery.css(elem, 'display') == 'none')
- y.display = 'block';
+ // Reset the display
+ y.display = oldDisplay;
+ if (jQuery.css(elem, "display") == "none")
+ y.display = "block";
+ }
// Hide the element if the "hide" operation was done
if ( options.hide )
- y.display = 'none';
+ y.display = "none";
// Reset the properties, if the item has been hidden or shown
if ( options.hide || options.show )
for ( var p in elem.curAnim )
- if (p == "opacity")
- jQuery.attr(y, p, elem.orig[p]);
- else
- y[p] = '';
+ jQuery.attr(y, p, elem.orig[p]);
}
// If a callback was provided, execute it
- if ( done && options.complete && options.complete.constructor == Function )
+ if ( done && jQuery.isFunction( options.complete ) )
// Execute the complete function
options.complete.apply( elem );
} else {
git.asbjorn.biz / jquery.git / blobdiff