From: jeresig Date: Mon, 11 Jan 2010 18:48:40 +0000 (-0500) Subject: Revert "Adding in backwards-compatiblity support for jQuery().bind/unbind/trigger... X-Git-Url: http://git.asbjorn.biz/?p=jquery.git;a=commitdiff_plain;h=366039a6f05ffa09630e95be604e3f4f26a33bd6 Revert "Adding in backwards-compatiblity support for jQuery().bind/unbind/trigger - and immediately deprecating it. Please explicitly use jQuery(document) in your code." This reverts commit e9d5947b4abbc052046585227892da0adcd56caf. --- diff --git a/src/event.js b/src/event.js index 6871327..c28e370 100644 --- a/src/event.js +++ b/src/event.js @@ -755,7 +755,6 @@ jQuery.each(["bind", "one"], function( i, name ) { for ( var key in type ) { this[ name ](key, data, type[key], fn); } - return this; } @@ -770,17 +769,11 @@ jQuery.each(["bind", "one"], function( i, name ) { return fn.apply( this, arguments ); }) : fn; - if ( type === "unload" && name !== "one" ) { - this.one( type, data, fn, thisObject ); - - } else { - // Deprecated: Please don't expect an empty jQuery set to bind to document - (!this.selector && !this.context ? jQuery(document) : this).each(function() { + return type === "unload" && name !== "one" ? + this.one( type, data, fn, thisObject ) : + this.each(function() { jQuery.event.add( this, type, handler, data ); }); - } - - return this; }; }); @@ -794,20 +787,14 @@ jQuery.fn.extend({ return this; } - // Deprecated: Please don't expect an empty jQuery set to bind to document - (!this.selector && !this.context ? jQuery(document) : this).each(function() { + return this.each(function() { jQuery.event.remove( this, type, fn ); }); - - return this; }, trigger: function( type, data ) { - // Deprecated: Please don't expect an empty jQuery set to bind to document - (!this.selector && !this.context ? jQuery(document) : this).each(function() { + return this.each(function() { jQuery.event.trigger( type, data, this ); }); - - return this; }, triggerHandler: function( type, data ) { diff --git a/test/unit/event.js b/test/unit/event.js index 7111bb5..8a9e48b 100644 --- a/test/unit/event.js +++ b/test/unit/event.js @@ -118,19 +118,6 @@ test("bind(), trigger change on select", function() { }).trigger('change'); }); -test("bind/unbind/trigger on empty jQuery set", function() { - expect(1); - - jQuery().bind("test", function(){ - equals( this, document, "Handler triggered and bound on document." ); - }); - - jQuery().trigger("test"); - - jQuery().unbind("test"); - jQuery().trigger("test"); -}); - test("bind(), namespaced events, cloned events", function() { expect(6);