From: jaubourg Date: Sun, 16 Jan 2011 17:33:32 +0000 (+0100) Subject: Put the split to get the list of promise methods out of the promise method itself... X-Git-Url: http://git.asbjorn.biz/?p=jquery.git;a=commitdiff_plain;h=5798446b9816daca48e8c03791f4afc0ab0ac4cf Put the split to get the list of promise methods out of the promise method itself and also switched from jQuery.each to a while loop to remove as much overhead as possible. Thanks go to scott_gonzalez for reminding me of this. --- diff --git a/src/core.js b/src/core.js index 25ef22d..fbf6491 100644 --- a/src/core.js +++ b/src/core.js @@ -63,6 +63,9 @@ var jQuery = function( selector, context ) { // The deferred used on DOM ready readyList, + // Promise methods + promiseMethods = "then done fail isResolved isRejected promise".split( " " ), + // The ready event handler DOMContentLoaded, @@ -914,16 +917,18 @@ jQuery.extend({ isRejected: failDeferred.isResolved, // Get a promise for this deferred // If obj is provided, the promise aspect is added to the object - promise: function( obj ) { + // (i is used internally) + promise: function( obj , i ) { if ( obj == null ) { if ( promise ) { return promise; } promise = obj = {}; } - jQuery.each( "then done fail isResolved isRejected promise".split( " " ) , function( _ , method ) { - obj[ method ] = deferred[ method ]; - }); + i = promiseMethods.length; + while( i-- ) { + obj[ promiseMethods[ i ] ] = deferred[ promiseMethods[ i ] ]; + } return obj; }