From: Jörn Zaefferer Date: Wed, 31 Jan 2007 21:36:48 +0000 (+0000) Subject: Fix for #883 X-Git-Url: http://git.asbjorn.biz/?p=jquery.git;a=commitdiff_plain;h=a82b048db8c72dccb019e086e0ca50617df14915 Fix for #883 --- diff --git a/src/jquery/coreTest.js b/src/jquery/coreTest.js index a7b470e..0bb9727 100644 --- a/src/jquery/coreTest.js +++ b/src/jquery/coreTest.js @@ -102,7 +102,7 @@ test("attr(Hash)", function() { }); test("attr(String, Object)", function() { - expect(6); + expect(7); var div = $("div"); div.attr("foo", "bar"); var pass = true; @@ -110,6 +110,8 @@ test("attr(String, Object)", function() { if ( div.get(i).getAttribute('foo') != "bar" ) pass = false; } ok( pass, "Set Attribute" ); + + ok( $("#foo").attr({"width": null}), "Try to set an attribute to nothing" ); $("#name").attr('name', 'something'); ok( $("#name").attr('name') == 'something', 'Set name attribute' ); diff --git a/src/jquery/jquery.js b/src/jquery/jquery.js index 933e974..76f11d7 100644 --- a/src/jquery/jquery.js +++ b/src/jquery/jquery.js @@ -1281,7 +1281,7 @@ jQuery.extend({ var exclude = /z-?index|font-?weight|opacity|zoom|line-?height/i; // Handle passing in a number to a CSS property - if ( value.constructor == Number && type == "curCSS" && !exclude.test(prop) ) + if ( value && value.constructor == Number && type == "curCSS" && !exclude.test(prop) ) return value + "px"; return value;