From: Anton M <obhvsbypqghgc@gmail.com>
Date: Sun, 13 Feb 2011 22:03:46 +0000 (+0100)
Subject: Don't add "px" to unit-less properties when animating them. Fixes #4966.
X-Git-Url: http://git.asbjorn.biz/?p=jquery.git;a=commitdiff_plain;h=c5edf982d59977c506fececd504a3dbfd1a398dc

Don't add "px" to unit-less properties when animating them. Fixes #4966.
---

diff --git a/src/effects.js b/src/effects.js
index b067539..0b08bc2 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -189,7 +189,7 @@ jQuery.fn.extend({
 
 					if ( parts ) {
 						var end = parseFloat( parts[2] ),
-							unit = parts[3] || "px";
+							unit = parts[3] || jQuery.cssNumber[ name ] ? "" : "px";
 
 						// We need to compute starting value
 						if ( unit !== "px" ) {
@@ -348,7 +348,7 @@ jQuery.fx.prototype = {
 		this.startTime = jQuery.now();
 		this.start = from;
 		this.end = to;
-		this.unit = unit || this.unit || "px";
+		this.unit = unit || this.unit || jQuery.cssNumber[ this.prop ] ? "" : "px";
 		this.now = this.start;
 		this.pos = this.state = 0;
 
diff --git a/test/unit/effects.js b/test/unit/effects.js
index bab4f25..7fb1c7d 100644
--- a/test/unit/effects.js
+++ b/test/unit/effects.js
@@ -919,3 +919,13 @@ test("hide hidden elements, with animation (bug #7141)", function() {
 		});
 	});
 });
+
+test("animate unit-less properties (#4966)", 2, function() {
+	stop();
+	var div = jQuery( "<div style='z-index: 0'></div>" ).appendTo( "body" );
+	equal( div.css( "z-index" ), "0", "z-index is 0" );
+	div.animate({ zIndex: 2 }, function() {
+		equal( div.css( "z-index" ), "2", "z-index is 2" );
+		start();
+	});
+});