From 4b70f006f579fba24a882d80ca67f1971dbb4922 Mon Sep 17 00:00:00 2001 From: John Resig Date: Wed, 9 Dec 2009 13:28:58 -0800 Subject: [PATCH] Made .clone(true) also copy over element data. Fixes #4191. --- src/manipulation.js | 8 +------- test/unit/manipulation.js | 7 ++++++- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/manipulation.js b/src/manipulation.js index 0c2753e..930b3d9 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -277,13 +277,7 @@ function cloneCopyEvent(orig, ret) { return; } - var events = jQuery.data( orig[i], "events" ); - - for ( var type in events ) { - for ( var handler in events[ type ] ) { - jQuery.event.add( this, type, events[ type ][ handler ], events[ type ][ handler ].data ); - } - } + jQuery.data( this, jQuery.data( orig[i++] ) ); }); } diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js index 4631ead..6de3e14 100644 --- a/test/unit/manipulation.js +++ b/test/unit/manipulation.js @@ -549,7 +549,7 @@ test("replaceAll(String|Element|Array<Element>|jQuery)", function() { }); test("clone()", function() { - expect(28); + expect(30); equals( 'This is a normal link: Yahoo', jQuery('#en').text(), 'Assert text for #en' ); var clone = jQuery('#yahoo').clone(); equals( 'Try them out:Yahoo', jQuery('#first').append(clone).text(), 'Check for clone' ); @@ -594,6 +594,11 @@ test("clone()", function() { div = div.clone(true); equals( div.length, 1, "One element cloned" ); equals( div[0].nodeName.toUpperCase(), "DIV", "DIV element cloned" ); + + div = jQuery("
").data({ a: true, b: true }); + div = div.clone(true); + equals( div.data("a"), true, "Data cloned." ); + equals( div.data("b"), true, "Data cloned." ); }); if (!isLocal) { -- 1.7.10.4