From 82ba3709eec42dd8da33eb2023fda927166260eb Mon Sep 17 00:00:00 2001 From: Brandon Aaron Date: Thu, 15 May 2008 20:29:52 +0000 Subject: [PATCH] Reverted back to using the num helper method in offset.js --- src/offset.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/offset.js b/src/offset.js index b77a0cd..ef999d8 100644 --- a/src/offset.js +++ b/src/offset.js @@ -112,12 +112,14 @@ jQuery.fn.extend({ parentOffset = /^body|html$/i.test(offsetParent[0].tagName) ? { top: 0, left: 0 } : offsetParent.offset(); // Subtract element margins - offset.top -= parseInt( jQuery.curCSS( this[0], 'marginTop', true ), 10 ) || 0; - offset.left -= parseInt( jQuery.curCSS( this[0], 'marginLeft', true ), 10 ) || 0; + // note: when an element has margin: auto the offsetLeft and marginLeft + // are the same in Safari causing offset.left to incorrectly be 0 + offset.top -= num( this, 'marginTop' ); + offset.left -= num( this, 'marginLeft' ); // Add offsetParent borders - parentOffset.top += parseInt( jQuery.curCSS( offsetParent[0], 'borderTopWidth', true ), 10 ) || 0; - parentOffset.left += parseInt( jQuery.curCSS( offsetParent[0], 'borderLeftWidth', true ), 10 ) || 0; + parentOffset.top += num( offsetParent, 'borderTopWidth' ); + parentOffset.left += num( offsetParent, 'borderLeftWidth' ); // Subtract the two offsets results = { -- 1.7.10.4