From b4bb6e11268c5f2fb26ddc3ff564d8656cf58f93 Mon Sep 17 00:00:00 2001 From: jeresig Date: Thu, 9 Dec 2010 13:07:44 -0500 Subject: [PATCH] Backing out fb6c038bf00296480234c971a1664ac01ca1479e, was causing jQuery.param tests to fail - unfixes #7413. --- src/core.js | 6 ------ test/unit/core.js | 15 ++++----------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src/core.js b/src/core.js index 008a88c..346e52d 100644 --- a/src/core.js +++ b/src/core.js @@ -532,12 +532,6 @@ jQuery.extend({ }, isEmptyObject: function( obj ) { - - // Fixes #7413 Check to see if obj passes isPlainObject - if ( !jQuery.isPlainObject( obj ) ) { - return false; - } - for ( var name in obj ) { return false; } diff --git a/test/unit/core.js b/test/unit/core.js index 3cbf3f6..7057783 100644 --- a/test/unit/core.js +++ b/test/unit/core.js @@ -848,20 +848,13 @@ test("jQuery.makeArray", function(){ }); test("jQuery.isEmptyObject", function(){ - expect(11); + expect(2); equals(true, jQuery.isEmptyObject({}), "isEmptyObject on empty object literal" ); equals(false, jQuery.isEmptyObject({a:1}), "isEmptyObject on non-empty object literal" ); - equals(false, jQuery.isEmptyObject(1), "isEmptyObject on number (wrong argument type)"); - equals(false, jQuery.isEmptyObject(0), "isEmptyObject on falsy number (wrong argument type)"); - equals(false, jQuery.isEmptyObject("test"), "isEmptyObject on string (wrong argument type)"); - equals(false, jQuery.isEmptyObject(""), "isEmptyObject on falsy string (wrong argument type)"); - equals(false, jQuery.isEmptyObject([1,2,3]), "isEmptyObject on array (wrong argument type)"); - equals(false, jQuery.isEmptyObject([]), "isEmptyObject on an empty array (wrong argument type)"); - equals(false, jQuery.isEmptyObject(undefined), "isEmptyObject on undefined (wrong argument type)"); - equals(false, jQuery.isEmptyObject(false), "isEmptyObject on undefined (wrong argument type)"); - equals(false, jQuery.isEmptyObject(null), "isEmptyObject on null (wrong argument type)" ); - + + // What about this ? + // equals(true, jQuery.isEmptyObject(null), "isEmptyObject on null" ); }); test("jQuery.proxy", function(){ -- 1.7.10.4