fixed memory initialization bug in remove_font_transforms filter

[swftools.git] / lib / filters / remove_font_transforms.c

diff --git a/lib/filters/remove_font_transforms.c b/lib/filters/remove_font_transforms.c
index bdaae38..06b6300 100644 (file)
--- a/lib/filters/remove_font_transforms.c
+++ b/lib/filters/remove_font_transforms.c
@@ -31,7 +31,6 @@
 typedef struct _mymatrix {
     float m00,m01,m10,m11;
     char*id;
-    double size; // not hashed
 } mymatrix_t;
 
 static void* mymatrix_clone(const void*_m) {
@@ -52,6 +51,7 @@ static unsigned int mymatrix_hash(const void*_m) {
     h = crc32_add_bytes(h, (char*)&m->m01, sizeof(m->m01));
     h = crc32_add_bytes(h, (char*)&m->m10, sizeof(m->m10));
     h = crc32_add_bytes(h, (char*)&m->m11, sizeof(m->m11));
+    h = crc32_add_string(h, m->id);
     return h;
 }
 static void mymatrix_destroy(void*_m) {
@@ -74,7 +74,8 @@ static char mymatrix_equals(const void*_m1, const void*_m2) {
     return *(U32*)&m1->m00 == *(U32*)&m2->m00 &&
            *(U32*)&m1->m01 == *(U32*)&m2->m01 &&
            *(U32*)&m1->m10 == *(U32*)&m2->m10 &&
-           *(U32*)&m1->m11 == *(U32*)&m2->m11;
+           *(U32*)&m1->m11 == *(U32*)&m2->m11 &&
+          !strcmp(m1->id, m2->id);
 }
 type_t mymatrix_type = {
     dup: mymatrix_clone,
@@ -91,24 +92,32 @@ typedef struct _internal {
 
 #ifdef __GNUC__
 void __attribute__((noinline)) 
-     matrix_convert(gfxmatrix_t*in, const char*id, mymatrix_t*out)
+     matrix_convert(gfxmatrix_t*in, const char*id, mymatrix_t*out, gfxmatrix_t*scalematrix)
 #else
-void matrix_convert(gfxmatrix_t*in, const char*id, mymatrix_t*out)
+void matrix_convert(gfxmatrix_t*in, const char*id, mymatrix_t*out, gfxmatrix_t*scalematrix)
 #endif
 {
     double l1 = sqrt(in->m00 * in->m00 + in->m01 * in->m01);
     double l2 = sqrt(in->m10 * in->m10 + in->m11 * in->m11);
-    double l = l1+l2;
-    if(l < 1e-20) {
+    double l = (l1+l2)/2.0;
+    if(l < 1e-10) {
        memset(out, 0, sizeof(*out));
        return;
     }
     out->m00 = in->m00 / l;
-    out->m01 = in->m01 / l;
     out->m10 = in->m10 / l;
-    out->m11 = in->m11 / l;
+    out->m01 = -in->m01 / l;
+    out->m11 = -in->m11 / l;
     out->id = (char*)id;
-    out->size = l;
+
+    if(scalematrix) {
+       scalematrix->m00 = l;
+       scalematrix->m01 = 0;
+       scalematrix->m10 = 0;
+       scalematrix->m11 = -l;
+       scalematrix->tx = in->tx;
+       scalematrix->ty = in->ty;
+    }
 }
 
 typedef struct _matrixdata {
@@ -120,6 +129,7 @@ typedef struct _transformedfont {
     gfxfont_t*font;
     mymatrix_t matrix;
     int*used;
+    double dx;
 } transformedfont_t;
 
 static transformedfont_t* transformedfont_new(gfxfont_t*orig, mymatrix_t*m)
@@ -127,7 +137,12 @@ static transformedfont_t* transformedfont_new(gfxfont_t*orig, mymatrix_t*m)
     transformedfont_t*f = rfx_calloc(sizeof(transformedfont_t));
     f->orig = orig;
     f->matrix = *m;
-    f->used = malloc(sizeof(f->used[0])*orig->num_glyphs);
+    f->used = rfx_calloc(sizeof(f->used[0])*orig->num_glyphs);
+    int t;
+    for(t=0;t<orig->num_glyphs;t++) {
+       if(orig->glyphs[t].unicode==32)
+           f->used[t]=1; //always preserve the space char in fonts
+    }
     return f;
 }
 
@@ -135,7 +150,7 @@ static void pass1_drawchar(gfxfilter_t*f, gfxfont_t*font, int glyphnr, gfxcolor_
 {
     internal_t*i = (internal_t*)f->internal;
     mymatrix_t m;
-    matrix_convert(matrix, font->id, &m);
+    matrix_convert(matrix, font->id, &m, 0);
     transformedfont_t*fd = dict_lookup(i->matrices, &m);
     if(!fd) {
        fd = transformedfont_new(font, &m);
@@ -145,6 +160,21 @@ static void pass1_drawchar(gfxfilter_t*f, gfxfont_t*font, int glyphnr, gfxcolor_
     out->drawchar(out, font, glyphnr, color, matrix);
 }
 
+static void glyph_transform(gfxglyph_t*g, mymatrix_t*mm)
+{
+    gfxmatrix_t m;
+    m.m00 = mm->m00;
+    m.m01 = mm->m01;
+    m.m10 = mm->m10;
+    m.m11 = mm->m11;
+    m.tx = 0;
+    m.ty = 0;
+    g->line = gfxline_clone(g->line);
+    gfxline_transform(g->line, &m);
+    if(m.m00>0)
+       g->advance *= m.m00;
+}
+
 static gfxresult_t* pass1_finish(gfxfilter_t*f, gfxdevice_t*out)
 {
     internal_t*i = (internal_t*)f->internal;
@@ -157,7 +187,8 @@ static gfxresult_t* pass1_finish(gfxfilter_t*f, gfxdevice_t*out)
        int t;
        int count=0;
        for(t=0;t<fd->orig->num_glyphs;t++) {
-           if(fd->used[t]) count++;
+           if(fd->used[t]) 
+               count++;
        }
        font->num_glyphs = count;
        font->glyphs = rfx_calloc(sizeof(gfxglyph_t)*font->num_glyphs);
@@ -165,15 +196,48 @@ static gfxresult_t* pass1_finish(gfxfilter_t*f, gfxdevice_t*out)
        for(t=0;t<fd->orig->num_glyphs;t++) {
            if(fd->used[t]) {
                font->glyphs[count] = fd->orig->glyphs[t];
+               glyph_transform(&font->glyphs[count], &fd->matrix);
                fd->used[t] = count;
                count++;
            }
        }
+
+       /* adjust the origin so that every character is to the
+          right of the origin */
+       gfxbbox_t total = {0,0,0,0};
+       double average_xmax = 0;
+       for(t=0;t<count;t++) {
+           gfxline_t*line = font->glyphs[t].line;
+           gfxbbox_t b = gfxline_getbbox(line);
+           total = gfxbbox_expand_to_bbox(total, b);
+       }
+       if(count) 
+           average_xmax /= count;
+
+       fd->dx = -total.xmin;
+
+       font->ascent = total.ymax;
+       font->descent = -total.ymin;
+
+       for(t=0;t<count;t++) {
+           gfxline_t*line = font->glyphs[t].line;
+           while(line) {
+               line->x += fd->dx;
+               line->sx += fd->dx;
+               line = line->next;
+           }
+       }
        gfxfont_fix_unicode(font);
     }
     return out->finish(out);
 }
 
+static void pass2_addfont(gfxfilter_t*f, gfxfont_t*font, gfxdevice_t*out)
+{
+    /* we throw away original fonts, and do the addfont() for the transformed
+       fonts in the first drawchar() */
+}
+
 static void pass2_drawchar(gfxfilter_t*f, gfxfont_t*font, int glyphnr, gfxcolor_t*color, gfxmatrix_t*matrix, gfxdevice_t*out)
 {
     internal_t*i = (internal_t*)f->internal;
@@ -186,9 +250,11 @@ static void pass2_drawchar(gfxfilter_t*f, gfxfont_t*font, int glyphnr, gfxcolor_
     }
 
     mymatrix_t m;
-    matrix_convert(matrix, font->id, &m);
+    gfxmatrix_t scalematrix;
+    matrix_convert(matrix, font->id, &m, &scalematrix);
     transformedfont_t*d = dict_lookup(i->matrices, &m);
-    out->drawchar(out, d->font, d->used[glyphnr], color, matrix);
+    scalematrix.tx -= d->dx*scalematrix.m00;
+    out->drawchar(out, d->font, d->used[glyphnr], color, &scalematrix);
 }
 
 void gfxtwopassfilter_remove_font_transforms_init(gfxtwopassfilter_t*f)
@@ -204,6 +270,7 @@ void gfxtwopassfilter_remove_font_transforms_init(gfxtwopassfilter_t*f)
     f->pass1.internal = i;
 
     f->pass2.name = "remove font transforms pass 2";
+    f->pass2.addfont = pass2_addfont;
     f->pass2.drawchar = pass2_drawchar;
     f->pass2.internal = i;